You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/09 19:11:38 UTC

[GitHub] [spark] hvanhovell commented on a change in pull request #35790: [SPARK-38353][PYTHON] Move usage logging instrumentation util functions from pandas module to pyspark.util module

hvanhovell commented on a change in pull request #35790:
URL: https://github.com/apache/spark/pull/35790#discussion_r822993128



##########
File path: python/pyspark/util.py
##########
@@ -420,6 +425,153 @@ def _clean_py4j_conn_for_current_thread() -> None:
             finally:
                 thread_connection.close()
 
+local = threading.local()

Review comment:
       Should this be `_local`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org