You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Elliot Metsger (JIRA)" <ji...@codehaus.org> on 2010/08/13 13:47:32 UTC
[jira] Created: (MRELEASE-589) Resolved dependencies overwritten
when multiple subprojects with SNAPSHOT dependencies are released
Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released
---------------------------------------------------------------------------------------------------
Key: MRELEASE-589
URL: http://jira.codehaus.org/browse/MRELEASE-589
Project: Maven 2.x Release Plugin
Issue Type: Bug
Components: perform
Affects Versions: 2.0
Reporter: Elliot Metsger
Attachments: Fix.patch, Testcase.patch
The CheckDependencySnapshotsPhase does not properly maintain the Set of resolvedDependencies when there are multiple sub projects that have SNAPSHOT deps.
Given subproject one defines a snapshot on _artifactId_:
{code}
<project>
...
<dependency>
<groupId>external</groupId>
<artifactId>artifactId</artifactId>
<version>1.0-SNAPSHOT</version>
</dependency>
...
</project>
{code}
Given subproject two defines a snapshot on _artifactId2_:
{code}
<project>
...
<dependency>
<groupId>external</groupId>
<artifactId>artifactId2</artifactId>
<version>1.0-SNAPSHOT</version>
</dependency>
...
</project>
{code}
And you run {code}release:perform{code} on the parent project and resolve the snaps, I think you should expect the {{ReleaseDescriptor.getResolvedSnapshotDependencies()}} to contain two entries:
* {{groupId:artifactId}}
* {{groupId:artifactId2}}
But instead it only contains the most recently resolved dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-589) Resolved dependencies overwritten
when multiple subprojects with SNAPSHOT dependencies are released
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231906#action_231906 ]
Elliot Metsger commented on MRELEASE-589:
-----------------------------------------
Note that when integrating MRELEASE-583, the testcase will fail after the patch is applied. This is because MRELEASE-583 modifies the prompter to no longer ask for the next development version.
So the line in this testcase:
Mock mockPrompter = createMockPrompter( new String[] { "yes", "1", "yes", "1.1-SNAPSHOT", "yes", "1", "yes", "1.1-SNAPSHOT" } );
needs to be changed to:
Mock mockPrompter = createMockPrompter( new String[] { "yes", "1", "yes", "1.0", "yes", "1", "yes", "1.0" } );
> Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released
> ---------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-589
> URL: http://jira.codehaus.org/browse/MRELEASE-589
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: perform
> Affects Versions: 2.0
> Reporter: Elliot Metsger
> Attachments: Fix.patch, Testcase.patch
>
>
> The CheckDependencySnapshotsPhase does not properly maintain the Set of resolvedDependencies when there are multiple sub projects that have SNAPSHOT deps.
> Given subproject one defines a snapshot on _artifactId_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> Given subproject two defines a snapshot on _artifactId2_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId2</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> And you run {code}release:perform{code} on the parent project and resolve the snaps, I think you should expect the {{ReleaseDescriptor.getResolvedSnapshotDependencies()}} to contain two entries:
> * {{groupId:artifactId}}
> * {{groupId:artifactId2}}
> But instead it only contains the most recently resolved dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRELEASE-589) Resolved dependencies overwritten
when multiple subprojects with SNAPSHOT dependencies are released
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MRELEASE-589.
---------------------------------
Resolution: Fixed
Assignee: Brett Porter
Applied, thanks!
> Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released
> ---------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-589
> URL: http://jira.codehaus.org/browse/MRELEASE-589
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: perform
> Affects Versions: 2.0
> Reporter: Elliot Metsger
> Assignee: Brett Porter
> Fix For: 2.1
>
> Attachments: Fix.patch, Testcase.patch
>
>
> The CheckDependencySnapshotsPhase does not properly maintain the Set of resolvedDependencies when there are multiple sub projects that have SNAPSHOT deps.
> Given subproject one defines a snapshot on _artifactId_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> Given subproject two defines a snapshot on _artifactId2_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId2</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> And you run {code}release:perform{code} on the parent project and resolve the snaps, I think you should expect the {{ReleaseDescriptor.getResolvedSnapshotDependencies()}} to contain two entries:
> * {{groupId:artifactId}}
> * {{groupId:artifactId2}}
> But instead it only contains the most recently resolved dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-589) Resolved dependencies overwritten
when multiple subprojects with SNAPSHOT dependencies are released
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231907#action_231907 ]
Elliot Metsger commented on MRELEASE-589:
-----------------------------------------
Er, the goal in the description should be release:prepare not release:perform.
> Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released
> ---------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-589
> URL: http://jira.codehaus.org/browse/MRELEASE-589
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: perform
> Affects Versions: 2.0
> Reporter: Elliot Metsger
> Attachments: Fix.patch, Testcase.patch
>
>
> The CheckDependencySnapshotsPhase does not properly maintain the Set of resolvedDependencies when there are multiple sub projects that have SNAPSHOT deps.
> Given subproject one defines a snapshot on _artifactId_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> Given subproject two defines a snapshot on _artifactId2_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId2</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> And you run {code}release:perform{code} on the parent project and resolve the snaps, I think you should expect the {{ReleaseDescriptor.getResolvedSnapshotDependencies()}} to contain two entries:
> * {{groupId:artifactId}}
> * {{groupId:artifactId2}}
> But instead it only contains the most recently resolved dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-589) Resolved dependencies overwritten
when multiple subprojects with SNAPSHOT dependencies are released
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MRELEASE-589:
----------------------------------
Fix Version/s: 2.1
patches to review
> Resolved dependencies overwritten when multiple subprojects with SNAPSHOT dependencies are released
> ---------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-589
> URL: http://jira.codehaus.org/browse/MRELEASE-589
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: perform
> Affects Versions: 2.0
> Reporter: Elliot Metsger
> Fix For: 2.1
>
> Attachments: Fix.patch, Testcase.patch
>
>
> The CheckDependencySnapshotsPhase does not properly maintain the Set of resolvedDependencies when there are multiple sub projects that have SNAPSHOT deps.
> Given subproject one defines a snapshot on _artifactId_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> Given subproject two defines a snapshot on _artifactId2_:
> {code}
> <project>
> ...
> <dependency>
> <groupId>external</groupId>
> <artifactId>artifactId2</artifactId>
> <version>1.0-SNAPSHOT</version>
> </dependency>
> ...
> </project>
> {code}
> And you run {code}release:perform{code} on the parent project and resolve the snaps, I think you should expect the {{ReleaseDescriptor.getResolvedSnapshotDependencies()}} to contain two entries:
> * {{groupId:artifactId}}
> * {{groupId:artifactId2}}
> But instead it only contains the most recently resolved dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira