[GitHub] [spark] maropu commented on a change in pull request #29161: [SPARK-32365][SQL]Fix java.lang.IndexOutOfBoundsException: No group -1

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29161:
URL: https://github.com/apache/spark/pull/29161#discussion_r457099324



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -412,7 +412,10 @@ case class RegExpReplace(subject: Expression, regexp: Expression, rep: Expressio
 
 object RegExpExtract {
   def checkGroupIndex(groupCount: Int, groupIndex: Int): Unit = {
-    if (groupCount < groupIndex) {
+    if (groupIndex < 0) {
+      throw new IllegalArgumentException(
+        s"The specified group index cannot be less than zero")

Review comment:
       nit: remove `s` in the head.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org