You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by fe...@apache.org on 2008/02/15 21:29:05 UTC
svn commit: r628164 -
/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Author: ferdinand
Date: Fri Feb 15 12:29:05 2008
New Revision: 628164
URL: http://svn.apache.org/viewvc?rev=628164&view=rev
Log:
Changed image handling to solve problems with generated images and fop. Some improvement but not a complete solution.
Modified:
forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Modified: forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
URL: http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=628164&r1=628163&r2=628164&view=diff
==============================================================================
--- forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl (original)
+++ forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl Fri Feb 15 12:29:05 2008
@@ -1069,8 +1069,8 @@
</xsl:when>
<!-- relative to document -->
<xsl:otherwise>
- <xsl:value-of
- select="concat($xmlbasedir,@src)" />
+ cocoon://<xsl:value-of
+ select="@src" />
</xsl:otherwise>
</xsl:choose>
</xsl:variable>
Re: svn commit: r628164 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Posted by David Crossley <cr...@apache.org>.
Ferdinand Soethe wrote:
> After some more testing I found that most of the broken
> image problems are not new but never showed because old FOP
> did not report them.
>
> Running our current test sites with Forrest 0.8 I found many
> of the same images missing in the pdf that are reported to
> be missing now.
A note for the archives:
See notes in the other thread. There is a test document
associated with FOR-635. Anyway see the other thread at
http://mail-archives.apache.org/mod_mbox/forrest-dev/200802.mbox/%3c47B4619C.8010609@apache.org%3e
"Problem with fop94 locating an aart-image"
-David
> The fix at least solves the problem in committed.xml. Why it
> does is completely beyond me.
>
> Best regards,
> Ferdinand Soethe
>
> ferdinand@apache.org wrote:
> >Author: ferdinand
> >Date: Fri Feb 15 12:29:05 2008
> >New Revision: 628164
> >
> >URL: http://svn.apache.org/viewvc?rev=628164&view=rev
> >Log:
> >Changed image handling to solve problems with generated images and fop.
> >Some improvement but not a complete solution.
> >
> >Modified:
> > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> >
> >Modified:
> >forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> >URL:
> >http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=628164&r1=628163&r2=628164&view=diff
> >==============================================================================
> >---
> >forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl (original)
> >+++
> >forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl Fri Feb 15 12:29:05 2008
> >@@ -1069,8 +1069,8 @@
> > </xsl:when>
> > <!-- relative to document -->
> > <xsl:otherwise>
> >- <xsl:value-of
> >- select="concat($xmlbasedir,@src)" />
> >+ cocoon://<xsl:value-of
> >+ select="@src" />
> > </xsl:otherwise>
> > </xsl:choose>
> > </xsl:variable>
> >
> >
> >
>
Re: svn commit: r628164 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Posted by Ferdinand Soethe <fe...@apache.org>.
> jeje, like Jeremias explains the new fop is able to resolve special
> protocols like cocoon:// (I tested on the old one and it does not work
> there). This solves the problem I guess for most if not all image links
> since we can use cocoon pipelines to generate the image.
some right away, the others once we changed the pipelines, I
guess.
> Which are the images that fail, because this should actually fix all
> images? If not that can mean that we have another piece of code that is
> changing the image linking (or the when test are matching).
In the skinned site
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///icon-e.png
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///ellipse-2.png
> ERROR - Image not available:
> cocoon://ellipse.png
> ERROR - Image not available:
> cocoon://cocoon-pyramid.png
> ERROR - Image not available:
> cocoon://icon-d.png
> * [24/54] [0/0] 1.203s 143.4Kb samples1/linking.pdf
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///usemap.gif
> * [63/27] [0/0] 0.313s 105.3Kb samples1/usemap.pdf
> ERROR - Image not available:
> cocoon://cocoon-pyramid.png
> * [67/24] [0/0] 0.125s 104.9Kb samples1/ascii-art.pdf
Thanks for helping on this.
> Hmmm. That is strange. I just reverted my merger thinking that I had broken trunk. But it is still broken. Did I do something wrong reverting changes from 628175?
Btw. Do you know what broke trunk. Can I re-merge now that
we know that trunk was broken before?
Best regards,
Ferdinand Soethe
Re: svn commit: r628164 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Posted by Ferdinand Soethe <fe...@apache.org>.
> jeje, like Jeremias explains the new fop is able to resolve special
> protocols like cocoon:// (I tested on the old one and it does not work
> there). This solves the problem I guess for most if not all image links
> since we can use cocoon pipelines to generate the image.
some right away, the others once we changed the pipelines, I
guess.
> Which are the images that fail, because this should actually fix all
> images? If not that can mean that we have another piece of code that is
> changing the image linking (or the when test are matching).
In the skinned site
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///icon-e.png
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///ellipse-2.png
> ERROR - Image not available:
> cocoon://ellipse.png
> ERROR - Image not available:
> cocoon://cocoon-pyramid.png
> ERROR - Image not available:
> cocoon://icon-d.png
> * [24/54] [0/0] 1.203s 143.4Kb samples1/linking.pdf
> ERROR - Image not available: C:\forrest\fop94\build\test_skinned_site/src/documentation/resources/images///usemap.gif
> * [63/27] [0/0] 0.313s 105.3Kb samples1/usemap.pdf
> ERROR - Image not available:
> cocoon://cocoon-pyramid.png
> * [67/24] [0/0] 0.125s 104.9Kb samples1/ascii-art.pdf
Thanks for helping on this.
Best regards,
Ferdinand Soethe
Re: svn commit: r628164 -
/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Posted by Thorsten Scherler <th...@apache.org>.
On Fri, 2008-02-15 at 21:31 +0100, Ferdinand Soethe wrote:
> After some more testing I found that most of the broken
> image problems are not new but never showed because old FOP
> did not report them.
Yes I think so as well, having tested on the old fop.
>
> Running our current test sites with Forrest 0.8 I found many
> of the same images missing in the pdf that are reported to
> be missing now.
>
> The fix at least solves the problem in committed.xml. Why it
> does is completely beyond me.
jeje, like Jeremias explains the new fop is able to resolve special
protocols like cocoon:// (I tested on the old one and it does not work
there). This solves the problem I guess for most if not all image links
since we can use cocoon pipelines to generate the image.
The old way always expected a physical URI (file or http) the new fop
"URIResolver in the FOP-NG block delegates to Cocoon's SourceResolver
framework", meaning the image can be the result of a pipeline.
>
> Best regards,
> Ferdinand Soethe
>
> ferdinand@apache.org wrote:
> > Author: ferdinand
> > Date: Fri Feb 15 12:29:05 2008
> > New Revision: 628164
> >
> > URL: http://svn.apache.org/viewvc?rev=628164&view=rev
> > Log:
> > Changed image handling to solve problems with generated images and fop. Some improvement but not a complete solution.
> >
Which are the images that fail, because this should actually fix all
images? If not that can mean that we have another piece of code that is
changing the image linking (or the when test are matching).
> > Modified:
> > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> >
> > Modified: forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> > URL: http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=628164&r1=628163&r2=628164&view=diff
> > ==============================================================================
> > --- forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl (original)
> > +++ forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl Fri Feb 15 12:29:05 2008
> > @@ -1069,8 +1069,8 @@
> > </xsl:when>
> > <!-- relative to document -->
> > <xsl:otherwise>
> > - <xsl:value-of
> > - select="concat($xmlbasedir,@src)" />
> > + cocoon://<xsl:value-of
> > + select="@src" />
> > </xsl:otherwise>
> > </xsl:choose>
> > </xsl:variable>
Thanks Ferdinand.
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions
Re: svn commit: r628164 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Posted by Ferdinand Soethe <sa...@soethe.net>.
After some more testing I found that most of the broken
image problems are not new but never showed because old FOP
did not report them.
Running our current test sites with Forrest 0.8 I found many
of the same images missing in the pdf that are reported to
be missing now.
The fix at least solves the problem in committed.xml. Why it
does is completely beyond me.
Best regards,
Ferdinand Soethe
ferdinand@apache.org wrote:
> Author: ferdinand
> Date: Fri Feb 15 12:29:05 2008
> New Revision: 628164
>
> URL: http://svn.apache.org/viewvc?rev=628164&view=rev
> Log:
> Changed image handling to solve problems with generated images and fop. Some improvement but not a complete solution.
>
> Modified:
> forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
>
> Modified: forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> URL: http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=628164&r1=628163&r2=628164&view=diff
> ==============================================================================
> --- forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl (original)
> +++ forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl Fri Feb 15 12:29:05 2008
> @@ -1069,8 +1069,8 @@
> </xsl:when>
> <!-- relative to document -->
> <xsl:otherwise>
> - <xsl:value-of
> - select="concat($xmlbasedir,@src)" />
> + cocoon://<xsl:value-of
> + select="@src" />
> </xsl:otherwise>
> </xsl:choose>
> </xsl:variable>
>
>
>