AnalyzingInfixSuggester lookup to take Query instead of BooleanQuery?

[Arcadius Ahouansou <ar...@menelic.com>]

Looking at the lookup method at

https://github.com/apache/lucene-solr/blob/5767764a2b621fce76c0b0529ddde550fdc00307/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L493

The parameter
BooleanQuery contextQuery
could well be a TermQuery.

Is it worth generalizing that method to take as parameter the base Query
instead?

Thanks.

Re: AnalyzingInfixSuggester lookup to take Query instead of BooleanQuery?

[Michael McCandless <lu...@mikemccandless.com>]

That seems reasonable?

There is logic in that method to tease out the clauses of that
contextQuery and carefully handle the "all MUST_NOT" case, but we can
change that logic to check instanceof BooleanQuery?

Can you open an issue / patch?  Thanks!

Mike McCandless

http://blog.mikemccandless.com


On Tue, Jul 28, 2015 at 7:45 PM, Arcadius Ahouansou
<ar...@menelic.com> wrote:
>
> Looking at the lookup method at
>
> https://github.com/apache/lucene-solr/blob/5767764a2b621fce76c0b0529ddde550fdc00307/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L493
>
> The parameter
> BooleanQuery contextQuery
> could well be a TermQuery.
>
> Is it worth generalizing that method to take as parameter the base Query
> instead?
>
> Thanks.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org