You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jl...@apache.org on 2006/06/18 14:38:31 UTC

svn commit: r415126 - in /myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule: ScheduleMouseListener.java ScheduleTag.java UISchedule.java

Author: jlust
Date: Sun Jun 18 05:38:30 2006
New Revision: 415126

URL: http://svn.apache.org/viewvc?rev=415126&view=rev
Log:
some PMD violations removed

Modified:
    myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleMouseListener.java
    myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleTag.java
    myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/UISchedule.java

Modified: myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleMouseListener.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleMouseListener.java?rev=415126&r1=415125&r2=415126&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleMouseListener.java (original)
+++ myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleMouseListener.java Sun Jun 18 05:38:30 2006
@@ -28,5 +28,5 @@
      * 
      * @param event the mouse event
      */
-    public void processMouseEvent(ScheduleMouseEvent event);
+    void processMouseEvent(ScheduleMouseEvent event);
 }

Modified: myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleTag.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleTag.java?rev=415126&r1=415125&r2=415126&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleTag.java (original)
+++ myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/ScheduleTag.java Sun Jun 18 05:38:30 2006
@@ -33,7 +33,7 @@
  * @author Jurgen Lust (latest modification by $Author: jlust $)
  * @version $Revision: 392301 $
  */
-public class ScheduleTag extends UIComponentTag implements Serializable
+public class ScheduleTag extends UIComponentTag implements Serializable 
 {
     private static final long serialVersionUID = -5226785969160327763L;
     
@@ -86,8 +86,8 @@
 
     //~ Methods ----------------------------------------------------------------
 
-    private void addAttribute(Application app, UIComponent component,
-            String key, String value)
+    private void addAttribute(final Application app, final UIComponent component,
+            final String key, final String value)
     {
         if ((key != null) && (value != null))
         {
@@ -456,11 +456,11 @@
     public void release()
     {
         super.release();
-        visibleStartHour = null;
-        visibleEndHour = null;
-        workingStartHour = null;
-        workingEndHour = null;
-        headerDateFormat = null;
+        visibleStartHour = null; 
+        visibleEndHour = null; 
+        workingStartHour = null; 
+        workingEndHour = null; 
+        headerDateFormat = null; 
         value = null;
         immediate = null;
         actionListener = null;
@@ -708,7 +708,7 @@
             }
             else
             {
-                schedule.setVisibleStartHour(new Integer(visibleStartHour)
+                schedule.setVisibleStartHour(Integer.valueOf(visibleStartHour)
                         .intValue());
             }
         }
@@ -722,7 +722,7 @@
             }
             else
             {
-                schedule.setVisibleEndHour(new Integer(visibleEndHour)
+                schedule.setVisibleEndHour(Integer.valueOf(visibleEndHour)
                         .intValue());
             }
         }
@@ -736,7 +736,7 @@
             }
             else
             {
-                schedule.setWorkingStartHour(new Integer(workingStartHour)
+                schedule.setWorkingStartHour(Integer.valueOf(workingStartHour)
                         .intValue());
             }
         }
@@ -750,7 +750,7 @@
             }
             else
             {
-                schedule.setWorkingEndHour(new Integer(workingEndHour)
+                schedule.setWorkingEndHour(Integer.valueOf(workingEndHour)
                         .intValue());
             }
         }
@@ -1107,5 +1107,6 @@
     {
         this.expandToFitEntries = expandToFitEntries;
     }
+
 }
 //The End

Modified: myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/UISchedule.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/UISchedule.java?rev=415126&r1=415125&r2=415126&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/UISchedule.java (original)
+++ myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/schedule/UISchedule.java Sun Jun 18 05:38:30 2006
@@ -106,7 +106,7 @@
         super();
         setRendererType(DEFAULT_RENDERER_TYPE);
         scheduleListener = new ScheduleActionListener();
-        addActionListener(scheduleListener);
+        addActionListener(scheduleListener); 
     }
 
     /**
@@ -506,7 +506,7 @@
      */
     public void setVisibleEndHour(int visibleEndHour)
     {
-        this.visibleEndHour = new Integer(visibleEndHour);
+        this.visibleEndHour = Integer.valueOf(visibleEndHour);
     }
 
     /**