You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dong Lin <li...@gmail.com> on 2014/06/04 19:31:49 UTC

Re: Review Request 22063: Patch for KAFKA-1472

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/
-----------------------------------------------------------

(Updated June 4, 2014, 5:31 p.m.)


Review request for kafka.


Bugs: KAFKA-1472
    https://issues.apache.org/jira/browse/KAFKA-1472


Repository: kafka


Description (updated)
-------

version 2


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
  clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
  clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 

Diff: https://reviews.apache.org/r/22063/diff/


Testing
-------


Thanks,

Dong Lin

Re: Review Request 22063: Patch for KAFKA-1472

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/#review44913
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On June 6, 2014, 5:42 a.m., Dong Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22063/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 5:42 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1472
>     https://issues.apache.org/jira/browse/KAFKA-1472
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> global compression rate
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
>   clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
>   clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 
> 
> Diff: https://reviews.apache.org/r/22063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Re: Review Request 22063: Patch for KAFKA-1472

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/
-----------------------------------------------------------

(Updated June 6, 2014, 5:42 a.m.)


Review request for kafka.


Bugs: KAFKA-1472
    https://issues.apache.org/jira/browse/KAFKA-1472


Repository: kafka


Description (updated)
-------

global compression rate


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
  clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
  clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 

Diff: https://reviews.apache.org/r/22063/diff/


Testing
-------


Thanks,

Dong Lin

Re: Review Request 22063: Patch for KAFKA-1472

Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/
-----------------------------------------------------------

(Updated June 5, 2014, 5:14 p.m.)


Review request for kafka.


Bugs: KAFKA-1472
    https://issues.apache.org/jira/browse/KAFKA-1472


Repository: kafka


Description (updated)
-------

Provide per-topic and global compression rate averaged across closed batches. In case of unwritable and unused MemoryRcords, use 1.0 as default compression rate.


Diffs
-----

  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
  clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
  clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 

Diff: https://reviews.apache.org/r/22063/diff/


Testing
-------


Thanks,

Dong Lin

Re: Review Request 22063: Patch for KAFKA-1472

Posted by Dong Lin <li...@gmail.com>.

> On June 5, 2014, 4:19 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, lines 858-862
> > <https://reviews.apache.org/r/22063/diff/2/?file=603554#file603554line858>
> >
> >     Could we add a global compression-rate metric too?
> >

Sure! I will add this metric too.


- Dong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/#review44818
-----------------------------------------------------------


On June 4, 2014, 5:31 p.m., Dong Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22063/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 5:31 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1472
>     https://issues.apache.org/jira/browse/KAFKA-1472
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> version 2
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
>   clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
>   clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 
> 
> Diff: https://reviews.apache.org/r/22063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Re: Review Request 22063: Patch for KAFKA-1472

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22063/#review44818
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/22063/#comment79363>

    Could we add a global compression-rate metric too?
    


- Jun Rao


On June 4, 2014, 5:31 p.m., Dong Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22063/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 5:31 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1472
>     https://issues.apache.org/jira/browse/KAFKA-1472
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> version 2
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 9b1f5653548ba90defdae43940a5554066770b0a 
>   clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 
>   clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 428968cd38a7b12991f87868bf759926ff7e594e 
> 
> Diff: https://reviews.apache.org/r/22063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dong Lin
> 
>