You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/12 07:19:32 UTC
[GitHub] [skywalking-nodejs] zijin-m opened a new pull request #22: add context clear before new entry span
zijin-m opened a new pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22
Different requests are assigned to the same traceId causing data errors
Because request use old asyncState
So,I Add `clear` before `newEntrySpan`, Is there a better solution, or am I misunderstanding？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #22: add context clear before new entry span
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22#issuecomment-758460701
> So,I Add clear before newEntrySpan, Is there a better solution, or am I misunderstanding？
If the context is not cleared, then this should be a bug. The entry span doesn't mean the first span.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #22: add context clear before new entry span
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22#issuecomment-758475799
@kezhenxu94 may know more about the tech detail, but basically this fix seems not correct to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zijin-m closed pull request #22: add context clear before new entry span
Posted by GitBox <gi...@apache.org>.
zijin-m closed pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zijin-m commented on pull request #22: add context clear before new entry span
Posted by GitBox <gi...@apache.org>.
zijin-m commented on pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22#issuecomment-758466927
> > So,I Add clear before newEntrySpan, Is there a better solution, or am I misunderstanding？
>
> If the context is not cleared, then this should be a bug. The entry span doesn't mean the first span.
Yes, after my test, it seems that `AsyncLocalStorage` did not recreate the async context for the new request event, which caused `getStore` to obtain the asyncState of the **previous request event**, which may be related to the browser’s TCP Connection Reuse, because when I use ab or curl To test and there is no such problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zijin-m edited a comment on pull request #22: add context clear before new entry span
Posted by GitBox <gi...@apache.org>.
zijin-m edited a comment on pull request #22:
URL: https://github.com/apache/skywalking-nodejs/pull/22#issuecomment-758466927
> > So,I Add clear before newEntrySpan, Is there a better solution, or am I misunderstanding？
>
> If the context is not cleared, then this should be a bug. The entry span doesn't mean the first span.
Yes, after my test, it seems that `AsyncLocalStorage` did not recreate the async context for the new request event, which caused `getStore` to obtain the asyncState of the **previous request event**, which may be related to the browser’s TCP Connection Reuse, because when I use `ab` or `curl` for test and there is no such problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org