You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/26 13:49:31 UTC
[GitHub] [tvm] ibsidorenko opened a new pull request, #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
ibsidorenko opened a new pull request, #13659:
URL: https://github.com/apache/tvm/pull/13659
Now there is no way to disable passes in MetaShedule tuner. This commit adds new parameter `disabled_pass` in tuning API (`tune_relay`/`compile_relay`). It can be used for different experiments and non default behavoir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
ibsidorenko commented on PR #13659:
URL: https://github.com/apache/tvm/pull/13659#issuecomment-1365657715
cc @masahi @junrushao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13659:
URL: https://github.com/apache/tvm/pull/13659#issuecomment-1365202044
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Hzfengsy, @elvin-n, @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on a diff in pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
ibsidorenko commented on code in PR #13659:
URL: https://github.com/apache/tvm/pull/13659#discussion_r1058246630
##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -345,6 +350,7 @@ def compile_relay(
}
),
executor: Optional["relay.backend.Executor"] = None,
+ disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None,
Review Comment:
Done
##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -250,6 +252,7 @@ def tune_relay(
seed: Optional[int] = None,
module_equality: str = "structural",
num_tuning_cores: Union[Literal["physical", "logical"], int] = "physical",
+ disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
echuraev commented on code in PR #13659:
URL: https://github.com/apache/tvm/pull/13659#discussion_r1058071985
##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -250,6 +252,7 @@ def tune_relay(
seed: Optional[int] = None,
module_equality: str = "structural",
num_tuning_cores: Union[Literal["physical", "logical"], int] = "physical",
+ disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None,
Review Comment:
Could you please add information about this parameter to the docstring?
##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -345,6 +350,7 @@ def compile_relay(
}
),
executor: Optional["relay.backend.Executor"] = None,
+ disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None,
Review Comment:
Add information to doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ibsidorenko commented on pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
ibsidorenko commented on PR #13659:
URL: https://github.com/apache/tvm/pull/13659#issuecomment-1366545983
> Also, I have a question. Should we add a test for this option or not?
I thought about that... since this is rather trivial change, not a bug fixing + it can be checked with tuning only (time consuming operation) I decided not to add unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev merged pull request #13659: [MetaSchedule] Add "disabled_pass" option in tuning API
Posted by GitBox <gi...@apache.org>.
echuraev merged PR #13659:
URL: https://github.com/apache/tvm/pull/13659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org