You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/05/27 17:45:02 UTC
[jira] [Commented] (TAP5-2264) ResponseCompressionAnalyzerImpl
ignores 'tapestry.supress-compression' request attribute for assets and
modules
[ https://issues.apache.org/jira/browse/TAP5-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009820#comment-14009820 ]
ASF subversion and git services commented on TAP5-2264:
-------------------------------------------------------
Commit 3392881422f1f28bee7db38a158ec8d29fd5254b in tapestry-5's branch refs/heads/master from [~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=3392881 ]
TAP5-2264: disable gzip compression for asset/module requests when the InternalConstants.SUPPRESS_COMPRESSION request attribute is set
> ResponseCompressionAnalyzerImpl ignores 'tapestry.supress-compression' request attribute for assets and modules
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-2264
> URL: https://issues.apache.org/jira/browse/TAP5-2264
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Felix Gonschorek
> Assignee: Jochen Kemnade
> Priority: Minor
> Fix For: 5.4
>
>
> version: 5.4 alpha29
> for pages and component rendering requests tapestry respects the request attribute org.apache.tapestry5.internal.InternalConstants.SUPPRESS_COMPRESSION.
> for modules and assets the request attribute is not being checked in org.apache.tapestry5.internal.services.ResponseCompressionAnalyzerImpl.isGZipSupported().
> quick fix: provide a service override for ResponseCompressionAnalyzer with a additional check for this.request.getAttribute(InternalConstants.SUPPRESS_COMPRESSION) != null
> reason why we need this: android video playback is crashing when sending gzipped java script files / and or other content. so we want to disable gzip compression for android, even when android supports gzip compression in the Accept-Encoding header.
--
This message was sent by Atlassian JIRA
(v6.2#6252)