You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/14 19:26:04 UTC
[GitHub] [nifi] pcode93 opened a new pull request, #5153: NIFI-6501 Added configurable buffer queue size and timeout in MySQL CDC processor
pcode93 opened a new pull request, #5153:
URL: https://github.com/apache/nifi/pull/5153
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
#### Description of PR
This PR essentially reopens https://github.com/apache/nifi/pull/3616 (which was marked as stale and closed) and updates it to the current NiFi version.
The original PR addressed an issue, where a queue, used to store binlog events, would grow uncontrollably and could cause a NiFi node to go down.
The PR adds properties to set a maximum size for the queue along with a write timeout after which a waiting binlog event will be discarded.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5153: NIFI-6501 Added configurable buffer queue size and timeout in MySQL CDC processor
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #5153: NIFI-6501 Added configurable buffer queue size and timeout in MySQL CDC processor
URL: https://github.com/apache/nifi/pull/5153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5153: NIFI-6501 Added configurable buffer queue size and timeout in MySQL CDC processor
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #5153:
URL: https://github.com/apache/nifi/pull/5153#issuecomment-1354160457
I reopened this to review and after talking with @markap14 I don't think this is the approach we want. Instead, to protect data loss and avoid OOM errors, we think we should just block on the method adding the events and retry after the default 100ms timeout occurs trying to add the event. I can explain in more detail if you like, but I am also working on a PR that does this very thing in case you'd like to review it. Are you still actively working on this, and if so are you interested in reviewing my upcoming PR? Thank you in advance either way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org