[GitHub] [superset] rusackas commented on a diff in pull request #23741: feat: Migrates TreeMap chart

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #23741:
URL: https://github.com/apache/superset/pull/23741#discussion_r1178047215


##########
superset/examples/configs/charts/Commute_Time.yaml:
##########
@@ -15,35 +15,34 @@
 # specific language governing permissions and limitations
 # under the License.
 slice_name: Commute Time
-viz_type: treemap
+viz_type: treemap_v2
 params:
   adhoc_filters:
-  - clause: WHERE
-    comparator: Currently A Developer
-    expressionType: SIMPLE
-    filterOptionName: filter_fvi0jg9aii_2lekqrhy7qk
-    isExtra: false
-    isNew: false
-    operator: ==
-    sqlExpression: null
-    subject: developer_type
-  - clause: WHERE
-    comparator: 'NULL'
-    expressionType: SIMPLE
-    filterOptionName: filter_r5execgs1q8_hbav07lele
-    isExtra: false
-    isNew: false
-    operator: '!='
-    sqlExpression: null
-    subject: communite_time
+    - clause: WHERE

Review Comment:
   Is this not over-indented?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org