You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/04 11:30:57 UTC

[GitHub] [camel-k-runtime] squakez opened a new pull request, #919: fix(deps): brought back inheritance to camel deps

squakez opened a new pull request, #919:
URL: https://github.com/apache/camel-k-runtime/pull/919

   Closes #918
   
   <!-- Description -->
   
   We need to bring back the inheritance to the `camel-dependencies` pom as that contains information for the release. However, I've added an enforcer rule to make sure the `camel-version` is aligned with the `camel-dependencies` version. The first commit of this PR should fail to prove the rule is fine.
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix(deps): brought back inheritance to camel deps
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k-runtime] oscerd commented on a diff in pull request #919: fix(deps): brought back inheritance to camel deps

Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #919:
URL: https://github.com/apache/camel-k-runtime/pull/919#discussion_r1013908233


##########
pom.xml:
##########
@@ -19,6 +19,12 @@
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
+    <parent>
+        <groupId>org.apache.camel</groupId>
+        <artifactId>camel-dependencies</artifactId>
+        <version>3.18.0</version>

Review Comment:
   We released with 3.18.2 on 1.15.x



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k-runtime] oscerd merged pull request #919: fix(deps): brought back inheritance to camel deps

Posted by GitBox <gi...@apache.org>.
oscerd merged PR #919:
URL: https://github.com/apache/camel-k-runtime/pull/919


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k-runtime] squakez commented on a diff in pull request #919: fix(deps): brought back inheritance to camel deps

Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #919:
URL: https://github.com/apache/camel-k-runtime/pull/919#discussion_r1013912947


##########
pom.xml:
##########
@@ -19,6 +19,12 @@
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
+    <parent>
+        <groupId>org.apache.camel</groupId>
+        <artifactId>camel-dependencies</artifactId>
+        <version>3.18.0</version>

Review Comment:
   Yep. As I wrote in the description, I left intentionally to test it. In fact, the checks proved that right :) - I'll add a commit to fix that and test as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org