You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by ch...@apache.org on 2023/01/11 07:34:58 UTC
[bookkeeper] branch master updated: BP-60:Change PCBC limitStatsLogging default value to true (#3719)
This is an automated email from the ASF dual-hosted git repository.
chenhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 49ca9fe3b1 BP-60:Change PCBC limitStatsLogging default value to true (#3719)
49ca9fe3b1 is described below
commit 49ca9fe3b13d0b4f82579e5023d98928a4f4bb74
Author: wenbingshen <ol...@gmail.com>
AuthorDate: Wed Jan 11 15:34:51 2023 +0800
BP-60:Change PCBC limitStatsLogging default value to true (#3719)
### Motivation
Fixes #3718
---
.../src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java | 2 +-
bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java | 1 +
site3/website/docs/reference/config.md | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
index e8fc0126c3..4a87f7a7a4 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
@@ -1190,7 +1190,7 @@ public abstract class AbstractConfiguration<T extends AbstractConfiguration>
* the boolean flag indicating whether to limit stats logging
*/
public boolean getLimitStatsLogging() {
- return getBoolean(LIMIT_STATS_LOGGING, false);
+ return getBoolean(LIMIT_STATS_LOGGING, true);
}
/**
diff --git a/bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java b/bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java
index 102ca06343..2b0ba17a79 100644
--- a/bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java
+++ b/bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java
@@ -128,6 +128,7 @@ public class TestTLS extends BookKeeperClusterTestCase {
baseClientConf.setTLSProviderFactoryClass(TLSContextFactory.class.getName());
baseClientConf.setTLSClientAuthentication(true);
baseClientConf.setUseV2WireProtocol(useV2Protocol);
+ baseClientConf.setLimitStatsLogging(false);
switch (clientKeyStoreFormat) {
case PEM:
diff --git a/site3/website/docs/reference/config.md b/site3/website/docs/reference/config.md
index b4fb5801e7..dcab231f5e 100644
--- a/site3/website/docs/reference/config.md
+++ b/site3/website/docs/reference/config.md
@@ -267,7 +267,7 @@ The table below lists parameters that you can set to configure bookies. All conf
| --------- | ----------- | ------- |
| enableStatistics | Whether statistics are enabled for the bookie. | true |
| statsProviderClass | Stats provider class.<br />Options:<br /> - Prometheus : org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider<br /> - Codahale : org.apache.bookkeeper.stats.codahale.CodahaleMetricsProvider<br /> - Twitter Finagle : org.apache.bookkeeper.stats.twitter.finagle.FinagleStatsProvider<br /> - Twitter Ostrich : org.apache.bookkeeper.stats.twitter.ostrich.OstrichProvider<br /> - Twitter Science : org.apache.bookkeeper.stats.twitter.science.TwitterSta [...]
-| limitStatsLogging | option to limit stats logging | false |
+| limitStatsLogging | option to limit stats logging | true |
## Prometheus Metrics Provider Settings