You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ar...@apache.org on 2016/12/30 08:44:42 UTC
[02/12] storm git commit: STORM-1228: code review comments
STORM-1228: code review comments
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e5ae496e
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e5ae496e
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/e5ae496e
Branch: refs/heads/1.x-branch
Commit: e5ae496e78aaf7a20a05bcff9139e2a6fd1ad551
Parents: f6f35dd
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Authored: Mon Feb 29 17:55:29 2016 -0600
Committer: Balazs Kossovics <ba...@s4m.io>
Committed: Fri Dec 2 11:37:41 2016 +0100
----------------------------------------------------------------------
.../jvm/org/apache/storm/tuple/FieldsTest.java | 36 ++++++++++++--------
1 file changed, 22 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/e5ae496e/storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java
----------------------------------------------------------------------
diff --git a/storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java b/storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java
index a4abd4b..536be81 100644
--- a/storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java
+++ b/storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java
@@ -49,36 +49,41 @@ public class FieldsTest {
@Test
public void getDoesNotThrowWithValidIndexTest() {
- Assert.assertEquals(getFields().get(0), "foo");
- Assert.assertEquals(getFields().get(1), "bar");
+ Fields fields = getFields();
+ Assert.assertEquals(fields.get(0), "foo");
+ Assert.assertEquals(fields.get(1), "bar");
}
@Test(expected = IndexOutOfBoundsException.class)
public void getThrowsWhenOutOfBoundsTest() {
- getFields().get(3);
+ Fields fields = getFields(); // only has two items
+ fields.get(2);
}
@Test
public void fieldIndexTest() {
- Assert.assertEquals(getFields().fieldIndex("foo"), 0);
- Assert.assertEquals(getFields().fieldIndex("bar"), 1);
+ Fields fields = getFields();
+ Assert.assertEquals(fields.fieldIndex("foo"), 0);
+ Assert.assertEquals(fields.fieldIndex("bar"), 1);
}
@Test(expected = IllegalArgumentException.class)
public void fieldIndexThrowsWhenOutOfBoundsTest() {
- getFields().fieldIndex("baz");
+ new Fields("foo").fieldIndex("baz");
}
@Test
public void containsTest() {
- Assert.assertTrue(getFields().contains("foo"));
- Assert.assertTrue(getFields().contains("bar"));
- Assert.assertFalse(getFields().contains("baz"));
+ Fields fields = getFields();
+ Assert.assertTrue(fields.contains("foo"));
+ Assert.assertTrue(fields.contains("bar"));
+ Assert.assertFalse(fields.contains("baz"));
}
@Test
public void toListTest() {
- List<String> fieldList = getFields().toList();
+ Fields fields = getFields();
+ List<String> fieldList = fields.toList();
Assert.assertEquals(fieldList.size(), 2);
Assert.assertEquals(fieldList.get(0), "foo");
Assert.assertEquals(fieldList.get(1), "bar");
@@ -86,7 +91,8 @@ public class FieldsTest {
@Test
public void toIteratorTest() {
- Iterator<String> fieldIter = getFields().iterator();
+ Fields fields = getFields();
+ Iterator<String> fieldIter = fields.iterator();
Assert.assertTrue(
"First item is foo",
@@ -105,18 +111,20 @@ public class FieldsTest {
@Test
public void selectTest() {
+ Fields fields = getFields();
List<Object> second = Arrays.asList(new Object[]{"b"});
List<Object> tuple = Arrays.asList(new Object[]{"a", "b", "c"});
- List<Object> pickSecond = getFields().select(new Fields("bar"), tuple);
+ List<Object> pickSecond = fields.select(new Fields("bar"), tuple);
Assert.assertTrue(pickSecond.equals(second));
List<Object> secondAndFirst = Arrays.asList(new Object[]{"b", "a"});
- List<Object> pickSecondAndFirst = getFields().select(new Fields("bar", "foo"), tuple);
+ List<Object> pickSecondAndFirst = fields.select(new Fields("bar", "foo"), tuple);
Assert.assertTrue(pickSecondAndFirst.equals(secondAndFirst));
}
@Test(expected = NullPointerException.class)
public void selectingUnknownFieldThrowsTest() {
- getFields().select(new Fields("bar", "baz"), Arrays.asList(new Object[]{"a", "b", "c"}));
+ Fields fields = getFields();
+ fields.select(new Fields("bar", "baz"), Arrays.asList(new Object[]{"a", "b", "c"}));
}
}