[incubator-uniffle] branch master updated: [ISSUE-290] Make RpcNodePort and HttpNodePort optional (#305)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 8890ed68 [ISSUE-290] Make RpcNodePort and HttpNodePort optional (#305)
8890ed68 is described below

commit 8890ed68ca489ec3aa2db1fb0168c0546ad52894
Author: Rui Wang <ru...@databricks.com>
AuthorDate: Sun Nov 6 18:59:17 2022 -0800

    [ISSUE-290] Make RpcNodePort and HttpNodePort optional (#305)
    
    ### What changes were proposed in this pull request?
    This PR makes `RPC_SERVER_PORT` and `JETTY_HTTP_PORT` in RSS conf as optional by setting up default values into the config entries.
    
    ### Why are the changes needed?
    Feature.
    
    ### Does this PR introduce _any_ user-facing change?
    NO
    
    ### How was this patch tested?
    UT
---
 .../src/main/java/org/apache/uniffle/common/config/RssBaseConf.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java b/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
index 94a26268..cd895ccd 100644
--- a/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
+++ b/common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
@@ -37,7 +37,7 @@ public class RssBaseConf extends RssConf {
   public static final ConfigOption<Integer> RPC_SERVER_PORT = ConfigOptions
       .key("rss.rpc.server.port")
       .intType()
-      .noDefaultValue()
+      .defaultValue(19999)
       .withDescription("Shuffle server service port");
 
   public static final ConfigOption<Boolean> RPC_METRICS_ENABLED = ConfigOptions
@@ -49,7 +49,7 @@ public class RssBaseConf extends RssConf {
   public static final ConfigOption<Integer> JETTY_HTTP_PORT = ConfigOptions
       .key("rss.jetty.http.port")
       .intType()
-      .noDefaultValue()
+      .defaultValue(19998)
       .withDescription("jetty http port");
 
   public static final ConfigOption<Integer> JETTY_CORE_POOL_SIZE = ConfigOptions