You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Anoop Sam John (JIRA)" <ji...@apache.org> on 2014/08/19 05:51:18 UTC

[jira] [Commented] (HBASE-11774) Avoid allocating unnecessary tag iterators

    [ https://issues.apache.org/jira/browse/HBASE-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101817#comment-14101817 ] 

Anoop Sam John commented on HBASE-11774:
----------------------------------------

bq.Some scope creep on this patch in that regard, please check.
+1

Patch looks good.

CellUtil.tagsIterator() used without the tags length check in VisibilityUtils also. Might be good to fix there also?

> Avoid allocating unnecessary tag iterators
> ------------------------------------------
>
>                 Key: HBASE-11774
>                 URL: https://issues.apache.org/jira/browse/HBASE-11774
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11774.patch
>
>
> We can avoid an unnecessary object allocation, sometimes in hot code paths, by not creating a tag iterator if the cell's tag area is of length zero, signifying no tags present.



--
This message was sent by Atlassian JIRA
(v6.2#6252)