You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/04/26 17:33:57 UTC
Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
Bugs: AMBARI-16122
https://issues.apache.org/jira/browse/AMBARI-16122
Repository: ambari
Description
-------
- renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
- added logfeeder-properties too
- added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
- move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
ambari-web/app/data/HDP2/site_properties.js 92509d9
ambari-web/app/models/quick_links.js b7ad1ce
Diff: https://reviews.apache.org/r/46702/diff/
Testing
-------
Built own rpms locally and tries to install 4 node cluster with 3 solr
Unit testing is in progress...
Thanks,
Oliver Szabo
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Oliver Szabo <os...@hortonworks.com>.
> On April 27, 2016, 7:23 a.m., Miklos Gergely wrote:
> > Is it intentional that the words of the property names are separated by dots in the logsearch.properties.xml and logfeeder.properties.xml, but in the other files are separated by underscores? If there is some kind of logic behind it than it's fine, otherwise I believe we should have the same naming style for all the properties.
yes. mostly this is used for site.xml files and we are using underscores for environment properties, these are properties, its a convention here
- Oliver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130730
-----------------------------------------------------------
On April 26, 2016, 4:24 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 4:24 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 156a731
> ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
> ambari-web/app/data/HDP2/site_properties.js 92509d9
> ambari-web/app/models/quick_links.js b7ad1ce
>
> Diff: https://reviews.apache.org/r/46702/diff/
>
>
> Testing
> -------
>
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Miklos Gergely <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130730
-----------------------------------------------------------
Is it intentional that the words of the property names are separated by dots in the logsearch.properties.xml and logfeeder.properties.xml, but in the other files are separated by underscores? If there is some kind of logic behind it than it's fine, otherwise I believe we should have the same naming style for all the properties.
- Miklos Gergely
On April 26, 2016, 4:24 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 4:24 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 156a731
> ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
> ambari-web/app/data/HDP2/site_properties.js 92509d9
> ambari-web/app/models/quick_links.js b7ad1ce
>
> Diff: https://reviews.apache.org/r/46702/diff/
>
>
> Testing
> -------
>
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Miklos Gergely <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130758
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On April 26, 2016, 4:24 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 4:24 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 156a731
> ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
> ambari-web/app/data/HDP2/site_properties.js 92509d9
> ambari-web/app/models/quick_links.js b7ad1ce
>
> Diff: https://reviews.apache.org/r/46702/diff/
>
>
> Testing
> -------
>
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/
-----------------------------------------------------------
(Updated April 27, 2016, 11:21 a.m.)
Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
Changes
-------
fixed logsearch_ui_port property
Bugs: AMBARI-16122
https://issues.apache.org/jira/browse/AMBARI-16122
Repository: ambari
Description
-------
- renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
- added logfeeder-properties too
- added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
- move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 156a731
ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
ambari-web/app/data/HDP2/site_properties.js 92509d9
ambari-web/app/models/quick_links.js b7ad1ce
Diff: https://reviews.apache.org/r/46702/diff/
Testing
-------
Built own rpms locally and tries to install 4 node cluster with 3 solr
Unit testing is in progress...
Thanks,
Oliver Szabo
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/
-----------------------------------------------------------
(Updated April 26, 2016, 4:24 p.m.)
Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
Changes
-------
updated python tests
Bugs: AMBARI-16122
https://issues.apache.org/jira/browse/AMBARI-16122
Repository: ambari
Description
-------
- renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
- added logfeeder-properties too
- added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
- move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 156a731
ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
ambari-web/app/data/HDP2/site_properties.js 92509d9
ambari-web/app/models/quick_links.js b7ad1ce
Diff: https://reviews.apache.org/r/46702/diff/
Testing
-------
Built own rpms locally and tries to install 4 node cluster with 3 solr
Unit testing is in progress...
Thanks,
Oliver Szabo
Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not
getting reflected at the backend
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130632
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 26, 2016, 3:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 3:33 p.m.)
>
>
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use PropertiesFile python class for it if the logsearch/logfeeder properties are more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to logsearch_ui_port
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java f892f04
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java 3fac655
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json c6c324f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml aee3d16
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml 8563e28
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml ba6eb06
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml b76e3d1
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml fb775bf
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 0f17672
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py b3817da
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 5e12dde
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 3598380
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 1edf16a
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 190d4e2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 be0f259
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json 13abc68
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java af84e92
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java ceb11d8
> ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b
> ambari-web/app/data/HDP2/site_properties.js 92509d9
> ambari-web/app/models/quick_links.js b7ad1ce
>
> Diff: https://reviews.apache.org/r/46702/diff/
>
>
> Testing
> -------
>
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
>
>
> Thanks,
>
> Oliver Szabo
>
>