You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Arved Sandstrom <Ar...@chebucto.ns.ca> on 2001/02/08 03:46:47 UTC

Submitting Patches

Hi, all

I'd like to thank everyone that's been submitting code...we've had a lot of
good stuff come in.

I know it's easier for us committers, but for other developers, could I ask
that patches be used for code submissions, as opposed to full files? This is
not that hard to work-around, usually, but sometimes it is, and it adds extra
time & book-keeping. This isn't just a whim on my part: there are complete
guidelines for how source is handled at http://xml.apache.org/source.html. I'd
like to particularly direct your attention to the section on Patches.

There are diff implementations available for Windows, UNIX/Linux and MacOS, so
none of this ought to be a problem.

Thanks for your cooperation. Please remember that all this helps get your code
into CVS faster and with less problems.

Regards,
Arved Sandstrom

P.S. I've got the MIF stuff under control...no need to resubmit. This message
is not directly related to that code submission.

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [fop-dev] Re: Submitting Patches

Posted by Aaron Optimizer Digulla <di...@hepe.com>.
On Thu, Feb 08, 2001 at 06:30:15AM -0400, Arved Sandstrom wrote:

> >I had submitted a patch for viewBox support and text-anchor=start/middle/end.
> >What happened to them ? Should I submit them again ?
> 
> No need to resubmit. The first phase of me doing release stuff this weekend 
> will be to rationalize peoples' patches/code submissions against _our_ 
> submissions, and catch up any (like yours) that have slipped through the 
> cracks.

Thanks. I need these two patches badly for my project here (a course on
XP done in XML) :-)

Note: With the new version of SVGRenderer, I've found a better way
to do text-anchor. It's still a hack but fully contained in
renderText(). If you're going to use my hack, you might want a
copy of the new code. Just ask :-)

-- 
==============================================
Sowatec AG,       CH-8330 Pfäffikon (ZH)
Witzbergstr. 7,   http://www.sowatec.com
Tel: +41-(0)1-952 55 55
Fax: +41-(0)1-952 55 66
----------------------------------------------
Aaron "Optimizer" Digulla, digulla@sowatec.com
==============================================

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [fop-dev] Submitting Patches

Posted by Arved Sandstrom <Ar...@chebucto.ns.ca>.
At 09:24 AM 2/8/01 +0100, Aaron Optimizer Digulla wrote:
>On Wed, Feb 07, 2001 at 10:46:47PM -0400, Arved Sandstrom wrote:
>
>> Hi, all
>> 
>> I'd like to thank everyone that's been submitting code...we've had a lot of
>> good stuff come in.
>> 
>> I know it's easier for us committers, but for other developers, could I ask
>> that patches be used for code submissions, as opposed to full files?
This is
>> not that hard to work-around, usually, but sometimes it is, and it adds
extra
>> time & book-keeping. This isn't just a whim on my part: there are complete
>> guidelines for how source is handled at
http://xml.apache.org/source.html. I'd
>> like to particularly direct your attention to the section on Patches.
>> 
>> There are diff implementations available for Windows, UNIX/Linux and
MacOS, so
>> none of this ought to be a problem.
>> 
>> Thanks for your cooperation. Please remember that all this helps get
your code
>> into CVS faster and with less problems.
>
>I had submitted a patch for viewBox support and text-anchor=start/middle/end.
>What happened to them ? Should I submit them again ?

No need to resubmit. The first phase of me doing release stuff this weekend 
will be to rationalize peoples' patches/code submissions against _our_ 
submissions, and catch up any (like yours) that have slipped through the 
cracks.

Thanks for your patience.

Regards,
Arved

Fairly Senior Software Type
e-plicity (http://www.e-plicity.com)
Wireless * B2B * J2EE * XML --- Halifax, Nova Scotia


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: Submitting Patches

Posted by Satoshi Ishigami <is...@victokai.co.jp>.
On Wed, Feb 07, 2001 at 10:46:47PM -0400, Arved Sandstrom wrote:

> I know it's easier for us committers, but for other developers, could I ask
> that patches be used for code submissions, as opposed to full files? This is
> not that hard to work-around, usually, but sometimes it is, and it adds extra
> time & book-keeping. This isn't just a whim on my part: there are complete
> guidelines for how source is handled at http://xml.apache.org/source.html. I'd
> like to particularly direct your attention to the section on Patches.
> 
> There are diff implementations available for Windows, UNIX/Linux and MacOS, so
> none of this ought to be a problem.
> 
> Thanks for your cooperation. Please remember that all this helps get your code
> into CVS faster and with less problems.

I sent mail about a japanese patch today.
Sorry , I did not know how to submit a pathch then.

Should I create diff output files and submit them?


---
Satoshi Ishigami   VIC TOKAI, LTD.

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: [fop-dev] Submitting Patches

Posted by Aaron Optimizer Digulla <di...@hepe.com>.
On Wed, Feb 07, 2001 at 10:46:47PM -0400, Arved Sandstrom wrote:

> Hi, all
> 
> I'd like to thank everyone that's been submitting code...we've had a lot of
> good stuff come in.
> 
> I know it's easier for us committers, but for other developers, could I ask
> that patches be used for code submissions, as opposed to full files? This is
> not that hard to work-around, usually, but sometimes it is, and it adds extra
> time & book-keeping. This isn't just a whim on my part: there are complete
> guidelines for how source is handled at http://xml.apache.org/source.html. I'd
> like to particularly direct your attention to the section on Patches.
> 
> There are diff implementations available for Windows, UNIX/Linux and MacOS, so
> none of this ought to be a problem.
> 
> Thanks for your cooperation. Please remember that all this helps get your code
> into CVS faster and with less problems.

I had submitted a patch for viewBox support and text-anchor=start/middle/end.
What happened to them ? Should I submit them again ?

-- 
==============================================
Sowatec AG,       CH-8330 Pfäffikon (ZH)
Witzbergstr. 7,   http://www.sowatec.com
Tel: +41-(0)1-952 55 55
Fax: +41-(0)1-952 55 66
----------------------------------------------
Aaron "Optimizer" Digulla, digulla@sowatec.com
==============================================

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org