You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/31 16:09:49 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #19311: [FLINK-26968][state/heap] Bump CopyOnWriteStateMap entry version before write

rkhachatryan opened a new pull request #19311:
URL: https://github.com/apache/flink/pull/19311


   ## What is the purpose of the change
   
   ```
   CopyOnWriteStateMap copies the entry before returning it to the client
   for update. This also updates its state and entry versions.
   
   However, if the entry is NOT used by any snapshots, the versions
   will stay the same despite that state is going to be updated.
   
   With incremental checkpoints, this causes such updated version to
   be ignored in the next snapshot.
   
   This change bumps the state version in this case (entry version
   stays the same).
   ```
   
   ## Verifying this change
   
   Multiple IT cases in https://github.com/rkhachatryan/flink/tree/flip-151-full,
   e.g. 
    - `ProcessingTimeWindowCheckpointingITCase.testAggregatingTumblingProcessingTimeWindow 
    - `EventTimeWindowCheckpointingITCase.testSlidingTimeWindow`
    - `AggregateITCase.testWindowWithUnboundedAgg`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #19311: [FLINK-26968][state/heap] Bump CopyOnWriteStateMap entry version before write

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19311:
URL: https://github.com/apache/flink/pull/19311#issuecomment-1085583245


   Test failures unrelated, tests in private branch passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19311: [FLINK-26968][state/heap] Bump CopyOnWriteStateMap entry version before write

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19311:
URL: https://github.com/apache/flink/pull/19311#issuecomment-1084802860


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 49e0e87592da9da114634b8fd7a519af186d8292 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19311: [FLINK-26968][state/heap] Bump CopyOnWriteStateMap entry version before write

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19311:
URL: https://github.com/apache/flink/pull/19311#issuecomment-1084802860


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34055",
       "triggerID" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 49e0e87592da9da114634b8fd7a519af186d8292 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19311: [FLINK-26968][state/heap] Bump CopyOnWriteStateMap entry version before write

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19311:
URL: https://github.com/apache/flink/pull/19311#issuecomment-1084802860


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34055",
       "triggerID" : "49e0e87592da9da114634b8fd7a519af186d8292",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 49e0e87592da9da114634b8fd7a519af186d8292 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org