[jira] [Commented] (HBASE-19884) BucketEntryGroup's equals, hashCode and compareTo methods are not consistent

["Peter Somogyi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343357#comment-16343357 ] 

Peter Somogyi commented on HBASE-19884:
---------------------------------------

Before HBASE-19811 the equals method used reference comparison, was missing hashCode method and compareTo returned with {{Long.compare(this.overflow(), that.overflow());}}. To keep the original behavior keeping compareTo as it is now would be the right move and dropping equals method. Since it used reference equality we can just remove it.

CC: [~appy], [~huaxiang], [~zjushch]

> BucketEntryGroup's equals, hashCode and compareTo methods are not consistent
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-19884
>                 URL: https://issues.apache.org/jira/browse/HBASE-19884
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Peter Somogyi
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>
> BucketEntryGroup currently uses different fields to calculate compareTo, equals and hasCode.
> In some cases !a.equals(b) but a.compareTo(b) == 0. Javadoc of Comparator recommends that natural orderings be consistent with equals.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)