You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/02 12:36:20 UTC
[GitHub] [netbeans-jenkins-lib] ebarboni opened a new pull request, #73: remove platform + put more to nightlies
ebarboni opened a new pull request, #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73
This is an update to remove the generation of platform.
+
vsix to nightlies
mavenrepo zipped to nightly
installers to nightlies
if it's ok to merge it would be nice to force a build to test :D.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73#issuecomment-1377252345
Zip only maven repo _on ci-builds_ good with me. I just download "all files in zip" there anyway. Just should not be on nightlies - can't be locked, gets overwritten, etc. As long as we archive all artefacts on ci-builds that are pushed to nightlies I'm good with the changes. I don't think we should use publish to nightlies as a replacement for the archived artefacts, just as the download source for end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni merged pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73#issuecomment-1378554843
you're right, merging this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73#issuecomment-1377225875
@neilcsmith-net not sure we are ok there.
change isthe zip only maven repo instead of 1go of artifacts we do not use. If I remember well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73#issuecomment-1300411002
For maven I would try to get only the zip, as storing artefacts take long time.
keep all to dist. Noted the javadoc for removal later, trying to remove nbm also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on a diff in pull request #73: remove platform + put more to nightlies
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #73:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/73#discussion_r1011728419
##########
vars/asfMainNetBeansBuild.groovy:
##########
@@ -392,23 +396,26 @@ def doParallelClusters(cconfigs) {
// apidoc
publishToNightlies("/netbeans/apidocs/${env.BRANCH_NAME}","**/WEBZIP.zip")
- archiveArtifacts 'WEBZIP.zip'
+ archiveArtifacts 'WEBZIP.zip' // XXX REMOVE
junit testResults: "build-${clustername}-temp/nbbuild/build/javadoc/checklinks-errors.xml", allowEmptyResults:true
def localRepo = ".repository"
def netbeansbase = "build-${clustername}-temp/nbbuild"
sh "ant -f build-${clustername}-temp/build.xml getallmavencoordinates -Dmetabuild.branch=${branch}"
withMaven(maven:tooling.myMaven,jdk:tooling.jdktool,publisherStrategy: 'EXPLICIT',mavenLocalRepo: localRepo,options:[artifactsPublisher(disabled: true)])
{
- sh "mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.1:get -Dartifact=org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion} -Dmaven.repo.local=${env.WORKSPACE}/.repository -DremoteRepositories=apache.snapshots.https::::https://repository.apache.org/snapshots"
- def commonparam = "-Dexternallist=${netbeansbase}/build/external.info"
- //sh "mvn org.apache.netbeans.utilities:nb-repository-plugin:1.5:download ${commonparam} -DrepositoryUrl=https://repo.maven.apache.org/maven2"
- if (heavyrelease) { // skip mavenrepo for vscode
- sh "mvn org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms -DnetbeansInstallDirectory=${netbeansbase}/netbeans -DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips -DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc -DparentGAV=org.apache.netbeans:netbeans-parent:3 -DforcedVersion=${mavenVersion} -DskipInstall=true -DdeployUrl=file://${env.WORKSPACE}/mavenrepository"
- archiveArtifacts 'mavenrepository/**'
- }
- // make vsix available to dist to pickup (only for main release) need a maven setup
- sh "ant -f build-${clustername}-temp/java/java.lsp.server build-vscode-ext -Dvsix.version=${vsixversion} -Dmetabuild.branch=${branch}"
- sh "cp -r build-${clustername}-temp/java/java.lsp.server/build/*.vsix dist/vsix/"
+ sh "mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.1:get -Dartifact=org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion} -Dmaven.repo.local=${env.WORKSPACE}/.repository -DremoteRepositories=apache.snapshots.https::::https://repository.apache.org/snapshots"
+ def commonparam = "-Dexternallist=${netbeansbase}/build/external.info"
+ //sh "mvn org.apache.netbeans.utilities:nb-repository-plugin:1.5:download ${commonparam} -DrepositoryUrl=https://repo.maven.apache.org/maven2"
+ if (heavyrelease) { // skip mavenrepo for vscode
+ sh "mvn org.apache.netbeans.utilities:nb-repository-plugin:${repopluginversion}:populate ${commonparam} -DnetbeansNbmDirectory=${netbeansbase}/nbms -DnetbeansInstallDirectory=${netbeansbase}/netbeans -DnetbeansSourcesDirectory=${netbeansbase}/build/source-zips -DnetbeansJavadocDirectory=${netbeansbase}/build/javadoc -DparentGAV=org.apache.netbeans:netbeans-parent:3 -DforcedVersion=${mavenVersion} -DskipInstall=true -DdeployUrl=file://${env.WORKSPACE}/mavenrepository"
+ zip zipFile:'mavenrepo.zip',dir:'mavenrepository',archive:'false'
+ //archiveArtifacts 'mavenrepository/**'
+ publishToNightlies("/netbeans/candidate/mavenrepository","mavenrepo.zip")
+ }
+ // make vsix available to dist to pickup (only for main release) need a maven setup
+ sh "ant -f build-${clustername}-temp/java/java.lsp.server build-vscode-ext -Dvsix.version=${vsixversion} -Dmetabuild.branch=${branch}"
+ //sh "cp -r build-${clustername}-temp/java/java.lsp.server/build/*.vsix dist/vsix/"
Review Comment:
Isn't that line needed to archive vsix on build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists