You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/29 11:44:00 UTC

[GitHub] [hudi] wzx140 opened a new pull request, #6005: [MINOR] fix use of HoodieDataBlock#getRecordIterator

wzx140 opened a new pull request, #6005:
URL: https://github.com/apache/hudi/pull/6005

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wzx140 commented on pull request #6005: [HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
wzx140 commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1170010956

   @xushiyan ok. I'll pay attention next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169931748

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc0970038ca86605a35a12212e20de31b54cff62 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636) 
   * e28b53031a1fe8b3b1f760dde03080978cb6fae3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169945233

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637",
       "triggerID" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc0970038ca86605a35a12212e20de31b54cff62 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636) 
   * e28b53031a1fe8b3b1f760dde03080978cb6fae3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #6005: [HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169975387

   @wzx140 if you linked a jira in title, then you can remove MINOR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1170004011

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637",
       "triggerID" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc0970038ca86605a35a12212e20de31b54cff62 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636) 
   * e28b53031a1fe8b3b1f760dde03080978cb6fae3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #6005: [HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6005:
URL: https://github.com/apache/hudi/pull/6005


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #6005: [HUDI-4344] [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
yanghua commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169967381

   Ok, so make your PR title more reasonable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wzx140 commented on pull request #6005: [HUDI-4344] [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
wzx140 commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169960636

   @yanghua Thank you for your correction. This pr just fix compile error in release-feature-rfc46 after rebase on master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169887281

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc0970038ca86605a35a12212e20de31b54cff62 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [MINOR] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1169883468

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc0970038ca86605a35a12212e20de31b54cff62 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6005: [HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6005:
URL: https://github.com/apache/hudi/pull/6005#issuecomment-1170160672

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9636",
       "triggerID" : "dc0970038ca86605a35a12212e20de31b54cff62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637",
       "triggerID" : "e28b53031a1fe8b3b1f760dde03080978cb6fae3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e28b53031a1fe8b3b1f760dde03080978cb6fae3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9637) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org