You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2009/07/19 20:20:10 UTC
svn commit: r795584 - in /maven/components/trunk:
maven-compat/src/main/java/org/apache/maven/artifact/
maven-compat/src/main/java/org/apache/maven/artifact/repository/
maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/
maven-compa...
Author: bentmann
Date: Sun Jul 19 18:20:09 2009
New Revision: 795584
URL: http://svn.apache.org/viewvc?rev=795584&view=rev
Log:
o Replaced usage of StringBuffer with StringBuilder
Modified:
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/LegacyRepositoryLayout.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionRequest.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/Restriction.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/settings/validation/SettingsValidationResult.java
maven/components/trunk/maven-core/src/main/mdo/settings.mdo
maven/components/trunk/maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java
maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
maven/components/trunk/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/DefaultArtifact.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/DefaultArtifact.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/DefaultArtifact.java Sun Jul 19 18:20:09 2009
@@ -224,14 +224,14 @@
public String getDependencyConflictId()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder( 128 );
sb.append( getGroupId() );
sb.append( ":" );
appendArtifactTypeClassifierString( sb );
return sb.toString();
}
- private void appendArtifactTypeClassifierString( StringBuffer sb )
+ private void appendArtifactTypeClassifierString( StringBuilder sb )
{
sb.append( getArtifactId() );
sb.append( ":" );
@@ -276,7 +276,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
if ( getGroupId() != null )
{
sb.append( getGroupId() );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java Sun Jul 19 18:20:09 2009
@@ -167,7 +167,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( " id: " ).append( getId() ).append( "\n" );
sb.append( " url: " ).append( getUrl() ).append( "\n" );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java Sun Jul 19 18:20:09 2009
@@ -124,7 +124,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( " id: " ).append( getId() ).append( "\n" );
sb.append( " url: " ).append( getUrl() ).append( "\n" );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java Sun Jul 19 18:20:09 2009
@@ -47,7 +47,7 @@
{
ArtifactHandler artifactHandler = artifact.getArtifactHandler();
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( formatAsDirectory( artifact.getGroupId() ) ).append( PATH_SEPARATOR );
path.append( artifact.getArtifactId() ).append( PATH_SEPARATOR );
@@ -75,7 +75,7 @@
private String pathOfRepositoryMetadata( ArtifactMetadata metadata,
String filename )
{
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( formatAsDirectory( metadata.getGroupId() ) ).append( PATH_SEPARATOR );
if ( !metadata.storedInGroupDirectory() )
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java Sun Jul 19 18:20:09 2009
@@ -29,7 +29,7 @@
{
ArtifactHandler artifactHandler = artifact.getArtifactHandler();
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( artifact.getArtifactId() ).append( ARTIFACT_SEPARATOR ).append( artifact.getVersion() );
@@ -54,7 +54,7 @@
private String pathOfRepositoryMetadata( String filename )
{
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( filename );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/LegacyRepositoryLayout.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/LegacyRepositoryLayout.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/LegacyRepositoryLayout.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/LegacyRepositoryLayout.java Sun Jul 19 18:20:09 2009
@@ -43,7 +43,7 @@
{
ArtifactHandler artifactHandler = artifact.getArtifactHandler();
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( artifact.getGroupId() ).append( '/' );
path.append( artifactHandler.getDirectory() ).append( '/' );
@@ -71,7 +71,7 @@
private String pathOfRepositoryMetadata( ArtifactMetadata metadata,
String filename )
{
- StringBuffer path = new StringBuffer();
+ StringBuilder path = new StringBuilder( 128 );
path.append( metadata.getGroupId() ).append( PATH_SEPARATOR ).append( "poms" ).append( PATH_SEPARATOR );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java Sun Jul 19 18:20:09 2009
@@ -205,7 +205,7 @@
public String extendedToString()
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append( "\nRepository Metadata\n--------------------------" );
buffer.append( "\nGroupId: " ).append( getGroupId() );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java Sun Jul 19 18:20:09 2009
@@ -163,7 +163,7 @@
protected static String constructArtifactPath( List path,
String indentation )
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
if ( path != null )
{
@@ -194,7 +194,7 @@
List remoteRepositories,
List path )
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( message );
sb.append( LS );
@@ -249,7 +249,7 @@
String downloadUrl,
List path )
{
- StringBuffer sb = new StringBuffer( message );
+ StringBuilder sb = new StringBuilder( message );
if ( !"pom".equals( type ) )
{
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionRequest.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionRequest.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionRequest.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionRequest.java Sun Jul 19 18:20:09 2009
@@ -171,7 +171,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer()
+ StringBuilder sb = new StringBuilder()
.append( "REQUEST: " ).append( "\n" )
.append( "artifact: " ).append( artifact ).append( "\n" )
.append( artifactDependencies ).append( "\n" )
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java Sun Jul 19 18:20:09 2009
@@ -325,7 +325,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
if ( artifacts != null )
{
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java Sun Jul 19 18:20:09 2009
@@ -84,7 +84,7 @@
private static String constructMessage( List<Artifact> artifacts )
{
- StringBuffer buffer = new StringBuffer( "Missing:\n" );
+ StringBuilder buffer = new StringBuilder( "Missing:\n" );
buffer.append( "----------\n" );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java Sun Jul 19 18:20:09 2009
@@ -303,7 +303,7 @@
public String toString()
{
- StringBuffer buffer = new StringBuffer( "(" );
+ StringBuilder buffer = new StringBuilder( "(" );
for( Iterator iter = iterator(); iter.hasNext(); )
{
buffer.append( iter.next() );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java Sun Jul 19 18:20:09 2009
@@ -208,7 +208,7 @@
@Override
public String toString()
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
if ( majorVersion != null )
{
buf.append( majorVersion );
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java Sun Jul 19 18:20:09 2009
@@ -37,7 +37,7 @@
public String toString()
{
- StringBuffer buffer = new StringBuffer( "ManagedVersionMap (" + size() + " entries)\n" );
+ StringBuilder buffer = new StringBuilder( "ManagedVersionMap (" + size() + " entries)\n" );
Iterator iter = keySet().iterator();
while ( iter.hasNext() )
{
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/Restriction.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/Restriction.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/Restriction.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/Restriction.java Sun Jul 19 18:20:09 2009
@@ -181,7 +181,7 @@
public String toString()
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
buf.append( isLowerBoundInclusive() ? "[" : "(" );
if ( getLowerBound() != null )
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java Sun Jul 19 18:20:09 2009
@@ -504,7 +504,7 @@
}
else
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
for ( Iterator i = restrictions.iterator(); i.hasNext(); )
{
Restriction r = (Restriction) i.next();
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java Sun Jul 19 18:20:09 2009
@@ -737,7 +737,7 @@
}
}
- StringBuffer cleanedPath = new StringBuffer();
+ StringBuilder cleanedPath = new StringBuilder();
while ( !pathElements.isEmpty() )
{
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java Sun Jul 19 18:20:09 2009
@@ -73,7 +73,7 @@
return indentation + "There were no validation errors.";
}
- StringBuffer message = new StringBuffer();
+ StringBuilder message = new StringBuilder();
// if ( messages.size() == 1 )
// {
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java Sun Jul 19 18:20:09 2009
@@ -134,7 +134,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer()
+ StringBuilder sb = new StringBuilder()
.append( "REQUEST: " ).append( "\n" )
.append( "artifact: " ).append( mad ).append( "\n" )
.append( artifactDependencies ).append( "\n" )
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java Sun Jul 19 18:20:09 2009
@@ -326,7 +326,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
if ( artifacts != null )
{
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java Sun Jul 19 18:20:09 2009
@@ -352,7 +352,7 @@
public File getTouchfile( Artifact artifact )
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( artifact.getArtifactId() );
sb.append( '-' ).append( artifact.getBaseVersion() );
if ( artifact.getClassifier() != null )
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java Sun Jul 19 18:20:09 2009
@@ -54,7 +54,7 @@
public String extendedToString()
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append( "\nArtifact Metadata\n--------------------------" );
buffer.append( "\nGroupId: " ).append( getGroupId() );
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java Sun Jul 19 18:20:09 2009
@@ -455,7 +455,7 @@
private String executionDescription( MojoExecution me, MavenProject project )
{
PluginDescriptor pd = me.getMojoDescriptor().getPluginDescriptor();
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder( 128 );
sb.append( "Executing " + pd.getArtifactId() + "[" + pd.getVersion() + "]: " + me.getMojoDescriptor().getGoal() + " on " + project.getArtifactId() );
return sb.toString();
}
@@ -1217,7 +1217,7 @@
if ( warnOfDeprecation )
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder( 128 );
buffer.append( "In mojo: " ).append( mojoDescriptor.getGoal() ).append( ", parameter: " ).append( param.getName() );
if ( param.getAlias() != null )
@@ -1338,7 +1338,7 @@
// Make sure the parameter is either editable/configurable, or else is NOT specified in the POM
if ( !parameter.isEditable() )
{
- StringBuffer errorMessage = new StringBuffer().append( "ERROR: Cannot override read-only parameter: " );
+ StringBuilder errorMessage = new StringBuilder( 128 ).append( "ERROR: Cannot override read-only parameter: " );
errorMessage.append( key );
errorMessage.append( " in goal: " ).append( goal.getFullGoalName() );
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java Sun Jul 19 18:20:09 2009
@@ -67,7 +67,7 @@
if ( obj != null && obj.getClass().isArray() )
{
int n = Array.getLength( obj );
- StringBuffer buf = new StringBuffer( 256 );
+ StringBuilder buf = new StringBuilder( 256 );
buf.append( '[' );
for ( int i = 0; i < n; i++ )
{
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java Sun Jul 19 18:20:09 2009
@@ -612,7 +612,7 @@
logger.fatalError( configurator.getClass().getName() + "#configureComponent(...) caused a linkage error (" + e.getClass().getName() + ") and may be out-of-date. Check the realms:" );
ClassRealm pluginRealm = mojoDescriptor.getPluginDescriptor().getClassRealm();
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( "Plugin realm = " + pluginRealm.getId() ).append( '\n' );
for ( int i = 0; i < pluginRealm.getURLs().length; i++ )
{
@@ -625,7 +625,7 @@
logger.fatalError( sb.toString() );
ClassRealm containerRealm = container.getContainerRealm();
- sb = new StringBuffer();
+ sb = new StringBuilder();
sb.append( "Container realm = " + containerRealm.getId() ).append( '\n' );
for ( int i = 0; i < containerRealm.getURLs().length; i++ )
{
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java Sun Jul 19 18:20:09 2009
@@ -102,7 +102,7 @@
public String identify()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder( 256 );
sb.append( executionId );
sb.append( configuration.toString() );
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java Sun Jul 19 18:20:09 2009
@@ -55,7 +55,7 @@
}
private static void decomposeParameterIntoUserInstructions( MojoDescriptor mojo, Parameter param,
- StringBuffer messageBuffer )
+ StringBuilder messageBuffer )
{
String expression = param.getExpression();
@@ -90,7 +90,7 @@
public String buildDiagnosticMessage()
{
- StringBuffer messageBuffer = new StringBuffer();
+ StringBuilder messageBuffer = new StringBuilder( 256 );
List params = getParameters();
MojoDescriptor mojo = getMojoDescriptor();
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/project/MavenProject.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/project/MavenProject.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/project/MavenProject.java Sun Jul 19 18:20:09 2009
@@ -1691,7 +1691,7 @@
@Override
public String toString()
{
- StringBuffer sb = new StringBuffer( 30 );
+ StringBuilder sb = new StringBuilder( 128 );
sb.append( "MavenProject: " );
sb.append( getGroupId() );
sb.append( ":" );
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/settings/validation/SettingsValidationResult.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/settings/validation/SettingsValidationResult.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/settings/validation/SettingsValidationResult.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/settings/validation/SettingsValidationResult.java Sun Jul 19 18:20:09 2009
@@ -93,7 +93,7 @@
return indentation + "There were no validation errors.";
}
- StringBuffer message = new StringBuffer();
+ StringBuilder message = new StringBuilder( 256 );
// if ( messages.size() == 1 )
// {
Modified: maven/components/trunk/maven-core/src/main/mdo/settings.mdo
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/mdo/settings.mdo?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/mdo/settings.mdo (original)
+++ maven/components/trunk/maven-core/src/main/mdo/settings.mdo Sun Jul 19 18:20:09 2009
@@ -663,7 +663,7 @@
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder( 128 );
sb.append( "Mirror[" );
sb.append( "id=" ).append( this.getId() );
sb.append( ",mirrorOf=" ).append( mirrorOf );
Modified: maven/components/trunk/maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java (original)
+++ maven/components/trunk/maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java Sun Jul 19 18:20:09 2009
@@ -1689,13 +1689,13 @@
assertEquals( expected, pom.getValue( expression ) );
}
- private static String createPath(List<String> elements)
+ private static String createPath( List<String> elements )
{
- StringBuffer buffer = new StringBuffer();
- for(String s : elements)
+ StringBuilder buffer = new StringBuilder( 256 );
+ for ( String s : elements )
{
- buffer.append(s).append(File.separator);
+ buffer.append( s ).append( File.separator );
}
- return buffer.toString().substring(0, buffer.toString().length() - 1);
+ return buffer.toString().substring( 0, buffer.toString().length() - 1 );
}
}
Modified: maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java (original)
+++ maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java Sun Jul 19 18:20:09 2009
@@ -152,7 +152,7 @@
{
List<String> cleaned = new ArrayList<String>();
- StringBuffer currentArg = null;
+ StringBuilder currentArg = null;
for ( int i = 0; i < args.length; i++ )
{
@@ -170,7 +170,7 @@
}
// start building an argument here.
- currentArg = new StringBuffer( arg.substring( 1 ) );
+ currentArg = new StringBuilder( arg.substring( 1 ) );
addedToBuffer = true;
}
Modified: maven/components/trunk/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java?rev=795584&r1=795583&r2=795584&view=diff
==============================================================================
--- maven/components/trunk/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java (original)
+++ maven/components/trunk/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java Sun Jul 19 18:20:09 2009
@@ -615,7 +615,7 @@
}
}
- StringBuffer cleanedPath = new StringBuffer();
+ StringBuilder cleanedPath = new StringBuilder( 128 );
while ( !pathElements.isEmpty() )
{