You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/11 15:46:27 UTC
[GitHub] [flink] yuchen-ecnu opened a new pull request, #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…
yuchen-ecnu opened a new pull request, #21485:
URL: https://github.com/apache/flink/pull/21485
… checkpoint tab
## What is the purpose of the change
In the Web UI, we link the pending or failed subtask to the corresponding TM for the job's checkpoint page, which helps to analyze the reason for the long checkpoint time or failure.
## Brief change log
- We add a link to jump to the corresponding TM for each subtask in the job checkpoint page.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework/code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduces a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #21485:
URL: https://github.com/apache/flink/pull/21485#discussion_r1046670197
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html:
##########
@@ -181,7 +186,19 @@
<td>{{ subTask['unaligned_checkpoint'] }}</td>
</ng-container>
<ng-container *ngIf="subTask['status'] === 'pending_or_failed'">
- <td colspan="8">n/a</td>
+ <td colspan="10">n/a</td>
+ <td>
+ <a
+ *ngIf="mapOfSubtask.get(subTask['index'])"
+ [routerLink]="[
+ '/task-manager',
+ mapOfSubtask.get(subTask['index'])['taskmanager-id'],
+ 'logs'
Review Comment:
I noticed the link has changed to `logs`, would you please share the new picture with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21485:
URL: https://github.com/apache/flink/pull/21485#issuecomment-1345588992
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78f3496a73d9d11e6617eff2b80a1d04f78cab6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "78f3496a73d9d11e6617eff2b80a1d04f78cab6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78f3496a73d9d11e6617eff2b80a1d04f78cab6c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuchen-ecnu commented on a diff in pull request #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…
Posted by GitBox <gi...@apache.org>.
yuchen-ecnu commented on code in PR #21485:
URL: https://github.com/apache/flink/pull/21485#discussion_r1051806981
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html:
##########
@@ -181,7 +186,19 @@
<td>{{ subTask['unaligned_checkpoint'] }}</td>
</ng-container>
<ng-container *ngIf="subTask['status'] === 'pending_or_failed'">
- <td colspan="8">n/a</td>
+ <td colspan="10">n/a</td>
+ <td>
+ <a
+ *ngIf="mapOfSubtask.get(subTask['index'])"
+ [routerLink]="[
+ '/task-manager',
+ mapOfSubtask.get(subTask['index'])['taskmanager-id'],
+ 'logs'
Review Comment:
Yes, I have updated the picture above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #21485: [FLINK-29997] Link to the taskmanager page in the expired sub-task of…
Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #21485:
URL: https://github.com/apache/flink/pull/21485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org