You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2016/10/24 17:29:59 UTC

[jira] [Created] (REEF-1650) Log warning about unclean evaluator shutdown only if evaluator is not closing yet

Mariia Mykhailova created REEF-1650:
---------------------------------------

             Summary: Log warning about unclean evaluator shutdown only if evaluator is not closing yet
                 Key: REEF-1650
                 URL: https://issues.apache.org/jira/browse/REEF-1650
             Project: REEF
          Issue Type: Bug
          Components: REEF-Common
            Reporter: Mariia Mykhailova
            Assignee: Mariia Mykhailova
            Priority: Minor


Current code in {{Evaluators.java}} is

{noformat}
    for (final EvaluatorManager evaluatorManager : evaluatorsCopy) {
      LOG.log(Level.WARNING, "Unclean shutdown of evaluator {0}", evaluatorManager.getId());
      if (!evaluatorManager.isClosedOrClosing()) {
        evaluatorManager.close();
      }
    }
{noformat}

The warning about unclean shutdown is posted even for evaluators which are already closed or closing. We should move the log inside {{if}} statement, so that it is written only if action is taken to close the evaluator forcefully.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)