[GitHub] [nuttx] GD32-MCU commented on a diff in pull request #9584: add gd32f470 support

["GD32-MCU (via GitHub)" <gi...@apache.org>]

GD32-MCU commented on code in PR #9584:
URL: https://github.com/apache/nuttx/pull/9584#discussion_r1242042097


##########
boards/arm/gd32f4/gd32f470zk-eval/Kconfig:
##########
@@ -0,0 +1,143 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+if ARCH_BOARD_GD32F470ZK_EVAL
+
+choice
+	prompt "Select Console wiring."
+	default GD32F470ZK_EVAL_CONSOLE_BOARD
+	---help---
+		Select where you will connect the console.
+
+		Virtual COM Port:
+
+		Advantage: Use the ST-Link as a console. No Extra wiring
+		needed.
+
+		Disadvantage: Not the best choice for initial bring up.
+
+		BOARD USART Connector:
+
+		Advantage: You have a shield so it is easy.
+
+		Disadvantage: You loose the use of the
+		other functions on PA9, PA10
+
+				GD32F470ZK_EVAL
+			USART0 GPIO
+			-- ----- --------- ----
+			RX    USART0_RX PA10
+			TX    USART0_TX PA9
+			-- ----- --------- ---
+
+config GD32F470ZK_EVAL_CONSOLE_BOARD
+	bool "Eval Com Connector"
+	select GD32_USART0
+	select USART0_SERIALDRIVER
+
+config GD32F470ZK_EVAL_CONSOLE_VIRTUAL
+	bool "Virtual Comport"
+	select GD32_USART3
+	select USART3_SERIALDRIVER
+
+config GD32F470ZK_EVAL_CONSOLE_NONE
+	bool "No Console"

Review Comment:
   Thanks for the adcvice, I, change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org