[GitHub] [comdev-site] sebbASF commented on a diff in pull request #100: Use pinned version of Hugo

["sebbASF (via GitHub)" <gi...@apache.org>]

sebbASF commented on code in PR #100:
URL: https://github.com/apache/comdev-site/pull/100#discussion_r1154169999


##########
Jenkinsfile:
##########
@@ -56,10 +68,13 @@ pipeline {
         stage('Build') {
             steps {
                 script {
-                    sh 'for i in $(which -a hugo) ; do echo $i; $i version; done'
-                    sh 'hugo version'
-                    sh "hugo --destination ${env.OUT_DIR}"
-                    sh "${env.PAGEFIND_DIR}/bin/pagefind --source ${env.OUT_DIR}"
+                    withEnv(["PATH+HUGO=${env.HUGO_DIR}/bin", "PATH+PAGEFIND=${env.PAGEFIND_DIR}/bin"]) {

Review Comment:
   Why is it necessary to change the PATH?
   Surely we want to ensure that hugo and pagefind are unconditionally run from the download location?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@community.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org