You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2017/06/12 09:35:16 UTC
Re: Review Request 59443: ATLAS-1823 UI - Change in base path URL for
few api/images to make it relative from path it is accessed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59443/#review177596
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On May 22, 2017, 11:12 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59443/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 11:12 a.m.)
>
>
> Review request for atlas, keval bhatt and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1823
> https://issues.apache.org/jira/browse/ATLAS-1823
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The currently in Atlas the base path for api and few image are relative to root of the application, ie it always resolves to http://<host><api>.
> Which causing issue when Atlas UI is accessed for Knox Proxy.
> Proposing following changes in path to make it relative from path it is accessed.
> - <img class="initialLoading" src="../img/ring.gif">
> + <img class="initialLoading" src="img/ring.gif">
> - baseUrl: '/api/atlas',
> - baseUrlV2: '/api/atlas/v2',
> + baseUrl: 'api/atlas',
> + baseUrlV2: 'api/atlas/v2',
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/main.scss 4b73577
> dashboardv2/public/index.html 72e11fb
> dashboardv2/public/js/utils/UrlLinks.js 82bd082
> dashboardv2/public/js/views/graph/LineageLayoutView.js f98672b
>
>
> Diff: https://reviews.apache.org/r/59443/diff/1/
>
>
> Testing
> -------
>
> Tested Atlas with CRUD operation.
> Atlas UI is loading fine without console error.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>