You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (JIRA)" <ji...@apache.org> on 2011/09/22 20:03:26 UTC
[jira] [Created] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Clean SaslServerCallbackHandler.java
------------------------------------
Key: ZOOKEEPER-1201
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Thomas Koch
Priority: Blocker
Attachments: ZOOKEEPER-1201.patch
Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1201:
-----------------------------------
Attachment: ZOOKEEPER-1201.patch
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Priority: Blocker
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112770#comment-13112770 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1201:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2017/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117208#comment-13117208 ]
Hudson commented on ZOOKEEPER-1201:
-----------------------------------
Integrated in ZooKeeper-trunk #1318 (See [https://builds.apache.org/job/ZooKeeper-trunk/1318/])
ZOOKEEPER-1201. Clean SaslServerCallbackHandler.java. (Thomas Koch via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1177191
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1201:
-----------------------------------
Attachment: ZOOKEEPER-1201.patch
Changed to getHostName() according to issue 1195
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112823#comment-13112823 ]
Eugene Koontz commented on ZOOKEEPER-1201:
------------------------------------------
Sorry; should not have checked "Ship it": it looks good *except* for the necessary change needed, noted in review.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115137#comment-13115137 ]
Mahadev konar commented on ZOOKEEPER-1201:
------------------------------------------
The change looks good to me. I'd to get this into 3.4 as well. Any objections?
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112803#comment-13112803 ]
Hadoop QA commented on ZOOKEEPER-1201:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496155/ZOOKEEPER-1201.patch
against trunk revision 1173949.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/581//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/581//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/581//console
This message is automatically generated.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1201:
-------------------------------------
Fix Version/s: 3.4.0
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1201:
-------------------------------------
Fix Version/s: 3.5.0
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112864#comment-13112864 ]
Hadoop QA commented on ZOOKEEPER-1201:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496168/ZOOKEEPER-1201.patch
against trunk revision 1173949.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/582//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/582//console
This message is automatically generated.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112790#comment-13112790 ]
Benjamin Reed commented on ZOOKEEPER-1201:
------------------------------------------
why is this classified as a blocker? it's really just defining constants for strings, changing an iterator, and extracting code blocks into methods right? i think the priority should be minor.
that said, the patch looks fine to me. eugene does this look okay to you?
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113112#comment-13113112 ]
Hadoop QA commented on ZOOKEEPER-1201:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496168/ZOOKEEPER-1201.patch
against trunk revision 1173949.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/585//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/585//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/585//console
This message is automatically generated.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112967#comment-13112967 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1201:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2017/#review2029
-----------------------------------------------------------
Ship it!
+1, thanks Thomas.
- Eugene
On 2011-09-22 19:40:04, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2017/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-22 19:40:04)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1201.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1201
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java b3faa79
bq.
bq. Diff: https://reviews.apache.org/r/2017/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112822#comment-13112822 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1201:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2017/#review2026
-----------------------------------------------------------
Ship it!
Looks good; the code is much improved. However please note important change regarding ZOOKEEPER-1195.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4572>
Good point: "credentials" should be final.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4573>
More concise, good.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4574>
See https://issues.apache.org/jira/browse/ZOOKEEPER-1195 : this should be kerberosName.getHostName(), not kerberosName.getServiceName().
- Eugene
On 2011-09-22 18:04:41, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2017/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-22 18:04:41)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1201.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1201
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java b3faa79
bq.
bq. Diff: https://reviews.apache.org/r/2017/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1201) Clean
SaslServerCallbackHandler.java
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112855#comment-13112855 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1201:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2017/
-----------------------------------------------------------
(Updated 2011-09-22 19:40:04.644049)
Review request for zookeeper.
Summary
-------
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch, ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira