You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/11/27 10:43:53 UTC

[GitHub] incubator-brooklyn pull request: SoftwareProcess.dontRequireTtyFor...

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1071#issuecomment-160097198
  
    looks good.  is there a situation where in-place `sed` doesn't work?  or is the `visudo` only used to give fail-fast if we edit wrongly?  worth a comment in code to address.
    
    (btw you comment that you exclude test sudoers file from rat but i don't see that; it looks like it has the appropriate license header which is actually better.)
    
    nice tests.  good enough to merge, so merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---