You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/11/28 23:57:06 UTC

DO NOT REPLY [Bug 41062] New: - Defect reading hyphenation patterns

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41062>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41062

           Summary: Defect reading hyphenation patterns
           Product: Fop
           Version: all
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: j3322ptm@yahoo.de


The PatternParser.characters method used for parsing patterns and other things
from hyphenation XML files can't cope with the parser splitting text in multiple
character events. This may lead to patterns crossing a buffer boundary to be
parsed as two wrong patterns.
Furthermore, the implementation is quite ineffective:
- copying the characters into a StringBuffer is unnecessary
- the tokenizer moves the whole array
The readToken is declared to return a string, but it always returns null and
stores the token in a class variable (horrible design).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41062] - Defect reading hyphenation patterns

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41062>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41062





------- Additional Comments From j3322ptm@yahoo.de  2006-11-28 14:59 -------
Umm, delete the comment about readToken always returning null. The design is
still somewhat horrible.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41062] - Defect reading hyphenation patterns

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41062>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41062





------- Additional Comments From j3322ptm@yahoo.de  2006-11-28 15:33 -------
Further points
- Using a ternary tree for the charclass arrays seems to be wasteful. Two
  parallel arrays and a Array binary search should be sufficient.
- The charclass parser wont check whether a . (dot) represents a class. The
  dot is reserved as begin/end of word marker in patterns, using it als
  class representation will probably cause problems.
- The pattern parser wont check whether the non-digits in the patterns are
  actually charclass representations.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.