You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:59 UTC
Review Request 68068: Added tests for task metadata GC using the
default executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Qian Zhang.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This adds two tests that launch a long-lived and short-lived task
on the same executor. The tests expect the short-lived task's
metadata and sandbox to be garbage collected.
One test restarts the agent before GC to ensure recovery will
schedule completed tasks for GC too.
One existing test is modified due to the extra GC event from
task metadata.
Diffs
-----
src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e
Diff: https://reviews.apache.org/r/68068/diff/1/
Testing
-------
make check (OSX)
(Other platforms pending...)
Thanks,
Joseph Wu
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206583
-----------------------------------------------------------
src/tests/gc_tests.cpp
Lines 729 (patched)
<https://reviews.apache.org/r/68068/#comment289578>
Can we change to use `testing::Sequence` to guarantee the order of status updates for each task? You could take the test below as a reference.
https://github.com/apache/mesos/blob/e6c6ab856d4f4829cbe71b60e93bb2c1dc6b44bc/src/tests/default_executor_tests.cpp#L300:L374
src/tests/gc_tests.cpp
Lines 957 (patched)
<https://reviews.apache.org/r/68068/#comment289579>
Ditto.
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 3:01 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e
>
>
> Diff: https://reviews.apache.org/r/68068/diff/2/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206556
-----------------------------------------------------------
PASS: Mesos patch 68068 was successfully built and tested.
Reviews applied: `['68065', '68066', '68067', '68068']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1994/mesos-review-68068
- Mesos Reviewbot Windows
On July 26, 2018, 7:01 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated July 26, 2018, 7:01 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e
>
>
> Diff: https://reviews.apache.org/r/68068/diff/2/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206516
-----------------------------------------------------------
PASS: Mesos patch 68068 was successfully built and tested.
Reviews applied: `['68065', '68066', '68067', '68068']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1987/mesos-review-68068
- Mesos Reviewbot Windows
On July 26, 2018, 7:01 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated July 26, 2018, 7:01 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e
>
>
> Diff: https://reviews.apache.org/r/68068/diff/1/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206576
-----------------------------------------------------------
PASS: Mesos patch 68068 was successfully built and tested.
Reviews applied: `['68065', '68066', '68067', '68095', '68068']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1998/mesos-review-68068
- Mesos Reviewbot Windows
On July 26, 2018, 7:01 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated July 26, 2018, 7:01 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e
>
>
> Diff: https://reviews.apache.org/r/68068/diff/2/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review208157
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68065, 68066, 68067, 68095, 68068]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 22, 2018, 6:33 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
>
>
> Diff: https://reviews.apache.org/r/68068/diff/4/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review207764
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 68067.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68067`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2220/mesos-review-68068
Relevant logs:
- [apply-review-68067.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2220/mesos-review-68068/logs/apply-review-68067.log):
```
error: patch failed: docs/upgrades.md:449
error: docs/upgrades.md: patch does not apply
```
- Mesos Reviewbot Windows
On Aug. 22, 2018, 6:33 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
>
>
> Diff: https://reviews.apache.org/r/68068/diff/3/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review208238
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 23, 2018, 2:33 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 2:33 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
>
>
> Diff: https://reviews.apache.org/r/68068/diff/4/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review208075
-----------------------------------------------------------
PASS: Mesos patch 68068 was successfully built and tested.
Reviews applied: `['68065', '68066', '68067', '68095', '68068']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2255/mesos-review-68068
- Mesos Reviewbot Windows
On Aug. 22, 2018, 6:33 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds two tests that launch a long-lived and short-lived task
> on the same executor. The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
>
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
>
> One existing test is modified due to the extra GC event from
> task metadata.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
> src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
>
>
> Diff: https://reviews.apache.org/r/68068/diff/4/
>
>
> Testing
> -------
>
> make check (OSX)
>
> (Other platforms pending...)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68068: Added tests for task metadata GC using the
default executor.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 11:33 a.m.)
Review request for mesos, Gilbert Song and Qian Zhang.
Changes
-------
Rebase and change new tests to use `::testing::Sequence`.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This adds two tests that launch a long-lived and short-lived task
on the same executor. The tests expect the short-lived task's
metadata and sandbox to be garbage collected.
One test restarts the agent before GC to ensure recovery will
schedule completed tasks for GC too.
One existing test is modified due to the extra GC event from
task metadata.
Diffs (updated)
-----
src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421
src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831
Diff: https://reviews.apache.org/r/68068/diff/3/
Changes: https://reviews.apache.org/r/68068/diff/2-3/
Testing
-------
make check (OSX)
(Other platforms pending...)
Thanks,
Joseph Wu