[Impala-ASF-CR] IMPALA-5031: memcpy cannot take null arguments

["Jim Apple (Code Review)" <ge...@cloudera.org>]

Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11812 )

Change subject: IMPALA-5031: memcpy cannot take null arguments
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11812/1/be/src/runtime/string-buffer.h
File be/src/runtime/string-buffer.h:

http://gerrit.cloudera.org:8080/#/c/11812/1/be/src/runtime/string-buffer.h@93
PS1, Line 93: memcpy
> I see new_buffer is guarded here. Is this one not replaced bc buffer_ is as
UBSAN is a dynamic analysis - it instruments only the places where it actually catches your program violating the rules. In this case, since the line can only get executed when new_buffer is non-null and len_ > 0, this would already segfault if buffer_ were null, so the line never gets tickled, so UBSAN never catches an error.



-- 
To view, visit http://gerrit.cloudera.org:8080/11812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9acc8c32409e67253a987eb3d1fd7d921efcb51
Gerrit-Change-Number: 11812
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Nov 2018 13:31:10 +0000
Gerrit-HasComments: Yes