You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/03 14:24:31 UTC

[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #186: [YUNIKORN-283] Support query params to filter the apps using queue name/namespace for v1/apps endpoint

manirajv06 commented on a change in pull request #186:
URL: https://github.com/apache/incubator-yunikorn-core/pull/186#discussion_r464446936



##########
File path: pkg/webservice/handlers.go
##########
@@ -98,6 +107,20 @@ func getApplicationsInfo(w http.ResponseWriter, r *http.Request) {
 	}
 }
 
+func validateQueue(queueName string) error {
+	if queueName != "" {
+		queueNameArr := strings.Split(queueName, ".")
+		for _, name := range queueNameArr {
+			if !configs.QueueNameRegExp.MatchString(name) {
+				return fmt.Errorf("problem in queue query parameter parsing as queue param " +
+					"#{queueName} contains invalid queue name #{name}. Queue name must only have " +

Review comment:
       Has been mis leaded with the way editor showing statements. Corrected now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org