You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/09 07:21:39 UTC

[GitHub] lanking520 commented on a change in pull request #13046: [MXNET-1155] Add scala packageTest utility

lanking520 commented on a change in pull request #13046: [MXNET-1155] Add scala packageTest utility
URL: https://github.com/apache/incubator-mxnet/pull/13046#discussion_r240026376
 
 

 ##########
 File path: Makefile
 ##########
 @@ -600,61 +600,78 @@ rpkgtest:
 	Rscript -e 'res<-covr:::package_coverage("R-package");fileConn<-file(paste("r-package_coverage_",toString(runif(1)),".json"));writeLines(covr:::to_codecov(res), fileConn);close(fileConn)'
 
 scalaclean:
-	(cd $(ROOTDIR)/scala-package; \
+	(cd $(ROOTDIR)/scala-package && \
 
 Review comment:
   why we use a `&&` instead of `;`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services