You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/10 14:50:15 UTC
[GitHub] StefanRRichter commented on a change in pull request #7188:
[FLINK-10473][State TTL] TTL state incremental cleanup for heap backend
StefanRRichter commented on a change in pull request #7188: [FLINK-10473][State TTL] TTL state incremental cleanup for heap backend
URL: https://github.com/apache/flink/pull/7188#discussion_r246361402
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -269,5 +300,34 @@ public StateTtlConfig build() {
public boolean inFullSnapshot() {
return strategies.containsKey(Strategies.FULL_STATE_SCAN_SNAPSHOT);
}
+
+ public IncrementalCleanupStrategy getIncrementalCleanupStrategy() {
+ return (IncrementalCleanupStrategy) strategies.get(Strategies.INCREMENTAL_CLEANUP);
+ }
+ }
+
+ /** Configuration of cleanup strategy while taking the full snapshot. */
+ public static class IncrementalCleanupStrategy implements CleanupStrategies.CleanupStrategy {
+ private static final long serialVersionUID = 3109278696501988780L;
+
+ private final int cleanupSize;
Review comment:
I would suggest to add a comment about the meaning of the fields here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services