Re: Review Request 17524: Add one integration test for the new producer

[Guozhang Wang <gu...@linkedin.com>]

> On Jan. 30, 2014, 6:12 p.m., Jun Rao wrote:
> > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, lines 75-76
> > <https://reviews.apache.org/r/17524/diff/1/?file=454164#file454164line75>
> >
> >     Do we really want to print those out in an integration test?

I used this for checking the send.offset functionality. I think I can just use one callback that really prints the offset, and the rest for no-op.


- Guozhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33232
-----------------------------------------------------------


On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 2:24 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1233
>     https://issues.apache.org/jira/browse/KAFKA-1233
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1233.v1
> 
> 
> Diffs
> -----
> 
>   core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION 
>   project/Build.scala ddcfc4176e68933377590e095c07283083249f4a 
> 
> Diff: https://reviews.apache.org/r/17524/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>