[GitHub] [calcite-avatica] stoty commented on a change in pull request #147: CALCITE-4646 Update to Jetty 9.4.42.v20210604

[GitBox <gi...@apache.org>]

stoty commented on a change in pull request #147:
URL: https://github.com/apache/calcite-avatica/pull/147#discussion_r662858215



##########
File path: server/src/test/java/org/apache/calcite/avatica/server/BasicAuthHttpServerTest.java
##########
@@ -44,8 +44,8 @@
   private static String url;
 
   @BeforeClass public static void startServer() throws Exception {
-    final String userPropertiesFile = URLDecoder.decode(BasicAuthHttpServerTest.class
-        .getResource("/auth-users.properties").getFile(), "UTF-8");
+    final String userPropertiesFile = (new File(BasicAuthHttpServerTest.class
+        .getResource("/auth-users.properties").toURI())).getPath();

Review comment:
       @vlsi 
   AFAIK Avatica doesn't depend on Calcite by design, and org.apache.calcite.util.Sources is not part of Avatica.
   
   Would you like me to copy that class into Avatica, and use it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org