You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2023/07/25 17:42:34 UTC
[GitHub] [nifi] pvillard31 opened a new pull request, #7528: NIFI-11857 - CLI - recursively change version of components
pvillard31 opened a new pull request, #7528:
URL: https://github.com/apache/nifi/pull/7528
# Summary
[NIFI-11857](https://issues.apache.org/jira/browse/NIFI-11857) - CLI - recursively change version of components
With and without scoping the process group where this should be applied.
````
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 2.0.0-SNAPSHOT --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor -pgid 8e04f78a-0189-1000-0e6f-007ca6b51dbc
# Name ID Type Run Status Version
- -------------------------- ------------------------------------ -------------------------- ---------- --------------
1 ConvertExcelToCSVProcessor 8e050129-0189-1000-62ba-09fe4588412c ConvertExcelToCSVProcessor RUNNING 2.0.0-SNAPSHOT
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 1.22.0 --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor -pgid 8e04f78a-0189-1000-0e6f-007ca6b51dbc
# Name ID Type Run Status Version
- -------------------------- ------------------------------------ -------------------------- ---------- -------
1 ConvertExcelToCSVProcessor 8e050129-0189-1000-62ba-09fe4588412c ConvertExcelToCSVProcessor RUNNING 1.22.0
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 2.0.0-SNAPSHOT --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor
# Name ID Type Run Status Version
- -------------------------- ------------------------------------ -------------------------- ---------- --------------
1 ConvertExcelToCSVProcessor 8d695704-0189-1000-9326-47d088697fe3 ConvertExcelToCSVProcessor RUNNING 2.0.0-SNAPSHOT
2 ConvertExcelToCSVProcessor 8e050129-0189-1000-62ba-09fe4588412c ConvertExcelToCSVProcessor RUNNING 2.0.0-SNAPSHOT
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 1.22.0 --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor
# Name ID Type Run Status Version
- -------------------------- ------------------------------------ -------------------------- ---------- -------
1 ConvertExcelToCSVProcessor 8d695704-0189-1000-9326-47d088697fe3 ConvertExcelToCSVProcessor RUNNING 1.22.0
2 ConvertExcelToCSVProcessor 8e050129-0189-1000-62ba-09fe4588412c ConvertExcelToCSVProcessor RUNNING 1.22.0
````
With specifying the current version:
````
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 1.22.0 --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor --current-version 1.21.0
# Name ID Type Run Status Version
- -------------------------- ------------------------------------ -------------------------- ---------- -------
1 ConvertExcelToCSVProcessor 8d695704-0189-1000-9326-47d088697fe3 ConvertExcelToCSVProcessor RUNNING 1.22.0
% ./cli.sh nifi change-version-processor -u http://127.0.0.1:8080/nifi-api --group org.apache.nifi --artifact nifi-poi-nar --version 1.22.0 --extension-name org.apache.nifi.processors.poi.ConvertExcelToCSVProcessor --current-version 1.21.0
# Name ID Type Run Status Version
--- ----- ------------------------------------ ----- ---------- ----------
````
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7528: NIFI-11857 - CLI - recursively change version of processors
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #7528:
URL: https://github.com/apache/nifi/pull/7528#issuecomment-1650275518
Something similar will need to be done for other components: controller services, reporting tasks, parameter providers, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7528: NIFI-11857 - CLI - recursively change version of processors
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7528:
URL: https://github.com/apache/nifi/pull/7528#issuecomment-1690673788
Thanks for the reply @pvillard31, that's a very good point about Controller Services. It sounds like it is necessary to handle them separately, and thus calling them out in a separate command makes more sense. With that background, this approach looks good as it stands, and I can take a closer look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7528: NIFI-11857 - CLI - recursively change version of processors
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7528: NIFI-11857 - CLI - recursively change version of processors
URL: https://github.com/apache/nifi/pull/7528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7528: NIFI-11857 - CLI - recursively change version of processors
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #7528:
URL: https://github.com/apache/nifi/pull/7528#issuecomment-1690583418
Hey @exceptionfactory - thanks for looking into this. Not sure when I'll be able to find time to get back to this in the near future. The reason I didn't tackle controller services is that it raises some questions such as: after changing the version, when we re-enable the controller service, should we also restart referencing components? I could definitely look into reporting tasks though, should be easy. Thoughts for controller services?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org