You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/04/04 14:37:16 UTC

[GitHub] [arrow] icexelloss commented on a diff in pull request #34885: GH-34786: [C++] Fix output schema calculated by Substrait consumer for AggregateRel

icexelloss commented on code in PR #34885:
URL: https://github.com/apache/arrow/pull/34885#discussion_r1157355901


##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -85,8 +86,43 @@ std::vector<TypeHolder> ExtendWithGroupIdType(const std::vector<TypeHolder>& in_
   return aggr_in_types;
 }
 
-Result<const HashAggregateKernel*> GetKernel(ExecContext* ctx, const Aggregate& aggregate,
+void DefaultAggregateOptions(Aggregate* aggregate_ptr,

Review Comment:
   Why do we need to add this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org