You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/02/27 19:57:22 UTC
Review Request 31553: DRILL-2262: selecting columns of certain
datatypes
from a dictionary encoded parquet file created by drill fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31553/
-----------------------------------------------------------
Review request for drill and Steven Phillips.
Repository: drill-git
Description
-------
Added proper reader for DECIMAL9, DECIMAL18, TIME and TIMESTAMP for OPTIONAL/REQUIRED columns.
Updated ColumnReaderFactory to handle these cases
Added unit test to make sure they are read correctly
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java cbdc0b0
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java 707bc9c
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java 02b583a
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/columnreaders/TestColumnReaderFactory.java PRE-CREATION
exec/java-exec/src/test/resources/parquet/decimal_dictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/decimal_nodictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/time_dictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/time_nodictionary.parquet PRE-CREATION
Diff: https://reviews.apache.org/r/31553/diff/
Testing
-------
added unit tests to make sure DECIMAL9, DECIMAL18, TIME and TIMESTAMP are read correctly with/without DICTIONARY encoding.
all unit tests pass along with functional, customer and tpch100
Thanks,
abdelhakim deneche
Re: Review Request 31553: DRILL-2262: selecting columns of certain
datatypes
from a dictionary encoded parquet file created by drill fails
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31553/
-----------------------------------------------------------
(Updated March 3, 2015, 5:39 p.m.)
Review request for drill and Steven Phillips.
Bugs: DRILL-2262
https://issues.apache.org/jira/browse/DRILL-2262
Repository: drill-git
Description
-------
Added proper reader for DECIMAL9, DECIMAL18, TIME and TIMESTAMP for OPTIONAL/REQUIRED columns.
Updated ColumnReaderFactory to handle these cases
Added unit test to make sure they are read correctly
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java cbdc0b0
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java 707bc9c
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java 02b583a
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/columnreaders/TestColumnReaderFactory.java PRE-CREATION
exec/java-exec/src/test/resources/parquet/decimal_dictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/decimal_nodictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/time_dictionary.parquet PRE-CREATION
exec/java-exec/src/test/resources/parquet/time_nodictionary.parquet PRE-CREATION
Diff: https://reviews.apache.org/r/31553/diff/
Testing
-------
added unit tests to make sure DECIMAL9, DECIMAL18, TIME and TIMESTAMP are read correctly with/without DICTIONARY encoding.
all unit tests pass along with functional, customer and tpch100
Thanks,
abdelhakim deneche