You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/26 16:29:31 UTC
[GitHub] [kafka] jsancio opened a new pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
jsancio opened a new pull request #9505:
URL: https://github.com/apache/kafka/pull/9505
Adds the changes to Fetch and FetchSnapshot as describe in KIP-630.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#issuecomment-721319905
Thanks for the review @chia7712 and sorry for the delay but I have decided to merge this PR with https://github.com/apache/kafka/pull/9553.
I will take care of your comments in that PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
Posted by GitBox <gi...@apache.org>.
jsancio commented on a change in pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#discussion_r537990130
##########
File path: clients/src/main/resources/common/message/FetchSnapshotRequest.json
##########
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 58,
+ "type": "request",
+ "name": "FetchSnapshotRequest",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ReplicaId", "type": "int32", "versions": "0+",
+ "about": "The broker ID of the follower." },
+ { "name": "MaxBytes", "type": "int32", "versions": "0+",
+ "about": "The maximum bytes to fetch from all of the snapshots." },
+ { "name": "Topics", "type": "[]TopicSnapshot", "versions": "0+",
+ "about": "The topics to fetch.", "fields": [
+ { "name": "Name", "type": "string", "versions": "0+", "entityType": "topicName",
+ "about": "The name of the topic to fetch." },
+ { "name": "Partitions", "type": "[]PartitionSnapshot", "versions": "0+",
+ "about": "The partitions to fetch.", "fields": [
+ { "name": "Index", "type": "int32", "versions": "0+",
Review comment:
FYI, @chia7712 I updated this field in https://github.com/apache/kafka/pull/9553 to `Partition` to match Fetch version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
Posted by GitBox <gi...@apache.org>.
jsancio commented on a change in pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#discussion_r537990223
##########
File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json
##########
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 58,
+ "type": "response",
+ "name": "FetchSnapshotResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+", "ignorable": true,
+ "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." },
+ { "name": "ErrorCode", "type": "int16", "versions": "0+", "ignorable": false,
+ "about": "The top level response error code." },
+ { "name": "Topics", "type": "[]TopicSnapshot", "versions": "0+",
+ "about": "The topics to fetch.", "fields": [
+ { "name": "Name", "type": "string", "versions": "0+", "entityType": "topicName",
+ "about": "The name of the topic to fetch." },
+ { "name": "Partitions", "type": "[]PartitionSnapshot", "versions": "0+",
+ "about": "The partitions to fetch.", "fields": [
+ { "name": "Index", "type": "int32", "versions": "0+",
Review comment:
FYI, @chia7712 I updated this field in https://github.com/apache/kafka/pull/9553 to `Partition` to match Fetch version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio closed pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
Posted by GitBox <gi...@apache.org>.
jsancio closed pull request #9505:
URL: https://github.com/apache/kafka/pull/9505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9505: KAFKA-10393: messages for fetch snapshot and fetch
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9505:
URL: https://github.com/apache/kafka/pull/9505#discussion_r512566562
##########
File path: clients/src/main/resources/common/message/FetchSnapshotRequest.json
##########
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 58,
+ "type": "request",
+ "name": "FetchSnapshotRequest",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ReplicaId", "type": "int32", "versions": "0+",
+ "about": "The broker ID of the follower." },
+ { "name": "MaxBytes", "type": "int32", "versions": "0+",
+ "about": "The maximum bytes to fetch from all of the snapshots." },
+ { "name": "Topics", "type": "[]TopicSnapshot", "versions": "0+",
+ "about": "The topics to fetch.", "fields": [
+ { "name": "Name", "type": "string", "versions": "0+", "entityType": "topicName",
+ "about": "The name of the topic to fetch." },
+ { "name": "Partitions", "type": "[]PartitionSnapshot", "versions": "0+",
+ "about": "The partitions to fetch.", "fields": [
+ { "name": "Index", "type": "int32", "versions": "0+",
Review comment:
it seems to me ```PartitionIndex``` is a more common name in protocol.
##########
File path: clients/src/main/resources/common/message/FetchSnapshotResponse.json
##########
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 58,
+ "type": "response",
+ "name": "FetchSnapshotResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+", "ignorable": true,
+ "about": "The duration in milliseconds for which the request was throttled due to a quota violation, or zero if the request did not violate any quota." },
+ { "name": "ErrorCode", "type": "int16", "versions": "0+", "ignorable": false,
+ "about": "The top level response error code." },
+ { "name": "Topics", "type": "[]TopicSnapshot", "versions": "0+",
+ "about": "The topics to fetch.", "fields": [
+ { "name": "Name", "type": "string", "versions": "0+", "entityType": "topicName",
+ "about": "The name of the topic to fetch." },
+ { "name": "Partitions", "type": "[]PartitionSnapshot", "versions": "0+",
+ "about": "The partitions to fetch.", "fields": [
+ { "name": "Index", "type": "int32", "versions": "0+",
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org