You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2026/01/10 00:41:07 UTC
[PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
villebro opened a new pull request, #37025:
URL: https://github.com/apache/superset/pull/37025
### SUMMARY
Currently the `LOCAL_EXTENSIONS` reloader stops working correctly if the `dist` folder is deleted with the following log:
```
2026-01-09 16:10:51,747:DEBUG:fsevents:Stopping because root path was changed
```
The proposed fix here does the following:
1. Watches the root of the extension
2. ignores changes other than those affecting files in the `dist` folder
With these changes, the reloader works correctly with `build` and `dev` mode:
```
2026-01-09 16:32:26,879:INFO:werkzeug: * Detected change in '/Users/ville/projects/superset/superset/extensions/local_extensions_watcher.py', reloading
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #37025:
URL: https://github.com/apache/superset/pull/37025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731469270
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37025:
URL: https://github.com/apache/superset/pull/37025#discussion_r2678026863
##########
superset/extensions/local_extensions_watcher.py:
##########
@@ -46,6 +46,10 @@ def on_any_event(self, event: Any) -> None:
if event.is_directory:
return
+ # Only trigger on changes to files in dist/ directory
+ if "/dist/" not in event.src_path:
Review Comment:
The path check using "/dist/" is not cross-platform compatible and will fail on Windows systems where paths use backslashes. Additionally, this substring check could incorrectly match files or directories containing "dist" in their name outside the actual dist directory (e.g., "/distributed/file.py"). Consider using os.path.sep to construct the path separator or using Path operations to check if "dist" is in the path components.
```suggestion
# Only trigger on changes to files in a dist directory (cross-platform)
src_path = Path(event.src_path)
if "dist" not in src_path.parts:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37025:
URL: https://github.com/apache/superset/pull/37025#discussion_r2678020861
##########
superset/extensions/local_extensions_watcher.py:
##########
@@ -91,9 +97,8 @@ def setup_local_extensions_watcher(app: Flask) -> None: # noqa: C901
logger.warning("LOCAL_EXTENSIONS path does not exist: %s", ext_path)
continue
- dist_path = ext_path / "dist"
- watch_dirs.append(str(dist_path))
- logger.info("Watching LOCAL_EXTENSIONS dist directory: %s", dist_path)
+ watch_dirs.append(str(ext_path))
+ logger.info("Watching LOCAL_EXTENSIONS directory: %s", ext_path)
Review Comment:
**Suggestion:** Bug when appending watch directories: the code appends the resolved `ext_path` directly even if it is a file path, and can add duplicate entries; ensure you watch a directory (use `ext_path` if it's a directory else `ext_path.parent`) and avoid adding the same path more than once. [logic error]
**Severity Level:** Minor β οΈ
```suggestion
watch_dir = ext_path if ext_path.is_dir() else ext_path.parent
watch_dir_str = str(watch_dir)
if watch_dir_str not in watch_dirs:
watch_dirs.append(watch_dir_str)
logger.info("Watching LOCAL_EXTENSIONS directory: %s", watch_dir_str)
```
<details>
<summary><b>Why it matters? β </b></summary>
This change is sensible: ext_path may resolve to a file, and scheduling a watcher with recursive=True on a file can be incorrect or surprising. Normalizing to a directory (ext_path if it's a dir, else ext_path.parent) and deduplicating avoids scheduling errors and redundant observers. The improved snippet addresses a real logic issue.
</details>
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/extensions/local_extensions_watcher.py
**Line:** 100:101
**Comment:**
*Logic Error: Bug when appending watch directories: the code appends the resolved `ext_path` directly even if it is a file path, and can add duplicate entries; ensure you watch a directory (use `ext_path` if it's a directory else `ext_path.parent`) and avoid adding the same path more than once.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
##########
superset/extensions/local_extensions_watcher.py:
##########
@@ -46,6 +46,10 @@ def on_any_event(self, event: Any) -> None:
if event.is_directory:
return
+ # Only trigger on changes to files in dist/ directory
+ if "/dist/" not in event.src_path:
Review Comment:
**Suggestion:** Cross-platform path check bug: the new check looks for the substring "/dist/" which will fail on Windows (backslashes) and can miss or incorrectly match some paths; use Path.parts (or os.path.sep-aware checks) and guard for missing/non-string src_path to reliably detect a "dist" component. [possible bug]
**Severity Level:** Critical π¨
```suggestion
# Only trigger on changes to files in dist/ directory (cross-platform)
src = getattr(event, "src_path", None)
if not isinstance(src, str):
return
if "dist" not in Path(src).parts:
```
<details>
<summary><b>Why it matters? β </b></summary>
The current substring check is brittle on Windows (backslashes) and will also blow up or behave oddly if event.src_path is missing/not a string. The proposed change to read src safely and check Path(src).parts for a "dist" component fixes a real cross-platform correctness issue. Path is already imported in the module, so the suggested approach fits cleanly.
</details>
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/extensions/local_extensions_watcher.py
**Line:** 49:50
**Comment:**
*Possible Bug: Cross-platform path check bug: the new check looks for the substring "/dist/" which will fail on Windows (backslashes) and can miss or incorrectly match some paths; use Path.parts (or os.path.sep-aware checks) and guard for missing/non-string src_path to reliably detect a "dist" component.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731154023
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | d9f2c6540bf4909c93f1c5033f1b7b6417a31c28 |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6961a0244824510008c91845 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-37025--superset-docs-preview.netlify.app](https://deploy-preview-37025--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37025--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731152729
## Nitpicks π
<table>
<tr><td>π <strong>No security issues identified</strong></td></tr>
<tr><td>β‘ <strong>Recommended areas for review</strong><br><br>
- [ ] <a href='https://github.com/apache/superset/pull/37025/files#diff-b3064963d3cd4f003e1fdd175eb67153ed57841be8a74d5b7471974ae6782d78R100-R101'><strong>Handler-scoped watch roots</strong></a><br>The handler currently has no knowledge of which extension roots are being watched; it only inspects the event path. To correctly validate that a `dist` change belongs to a watched extension, propagate the watched roots into the handler (or attach them to the handler instance) and validate the event path relative to those roots.<br>
- [ ] <a href='https://github.com/apache/superset/pull/37025/files#diff-b3064963d3cd4f003e1fdd175eb67153ed57841be8a74d5b7471974ae6782d78R49-R51'><strong>Cross-platform path check</strong></a><br>The new filter uses a literal string check "/dist/" on `event.src_path`. This is brittle on non-POSIX platforms (Windows uses backslashes) and can miss matches or produce false negatives. Prefer using Path-based checks that work with platform-specific separators.<br>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731154154
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #37025:
URL: https://github.com/apache/superset/pull/37025#discussion_r2678023676
##########
superset/extensions/local_extensions_watcher.py:
##########
@@ -46,6 +46,10 @@ def on_any_event(self, event: Any) -> None:
if event.is_directory:
return
+ # Only trigger on changes to files in dist/ directory
+ if "/dist/" not in event.src_path:
+ return
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Cross-platform path check needed</b></div>
<div id="fix">
The check for "/dist/" in event.src_path won't work on Windows, where paths use backslashes. This prevents the watcher from triggering on dist/ file changes on Windows systems, breaking local extension reloading there.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
# Only trigger on changes to files in dist/ directory
if "dist" not in Path(event.src_path).parts:
return
````
</div>
</details>
</div>
<small><i>Code Review Run #e371b9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731150017
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! π
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) Β·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) Β·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731150132
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(extensions): gracefully handle dist directory rebuilding [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37025:
URL: https://github.com/apache/superset/pull/37025#issuecomment-3731162217
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/37025?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.29%. Comparing base ([`53dddf4`](https://app.codecov.io/gh/apache/superset/commit/53dddf4db26d32ec86673a6d42b009cc49fbd09d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d9f2c65`](https://app.codecov.io/gh/apache/superset/commit/d9f2c6540bf4909c93f1c5033f1b7b6417a31c28?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/37025?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/extensions/local\_extensions\_watcher.py](https://app.codecov.io/gh/apache/superset/pull/37025?src=pr&el=tree&filepath=superset%2Fextensions%2Flocal_extensions_watcher.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy9sb2NhbF9leHRlbnNpb25zX3dhdGNoZXIucHk=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/37025?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #37025 +/- ##
===========================================
+ Coverage 0 48.29% +48.29%
===========================================
Files 0 642 +642
Lines 0 47901 +47901
Branches 0 5228 +5228
===========================================
+ Hits 0 23133 +23133
- Misses 0 24112 +24112
- Partials 0 656 +656
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/37025/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/37025/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.91% <0.00%> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/37025/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.50% <0.00%> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/37025/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.28% <0.00%> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/37025/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ΓΈ> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/37025?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org