You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/27 04:44:36 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5082: compile/flags: add FRAME_POINTER into Toolchain.defs
anchao opened a new pull request #5082:
URL: https://github.com/apache/incubator-nuttx/pull/5082
## Summary
compile/flags: add FRAME_POINTER into Toolchain.defs
compile/flags: remove redundant -fomit-frame-pointer from board flags
Reference:
https://github.com/torvalds/linux/blob/master/lib/Kconfig.debug#L437-L444
https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/debug/Kconfig#L286-L298
## Impact
N/A
## Testing
CI-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5082: compile/flags: add FRAME_POINTER into Toolchain.defs
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5082:
URL: https://github.com/apache/incubator-nuttx/pull/5082#discussion_r775505493
##########
File path: Kconfig
##########
@@ -1919,6 +1919,14 @@ config DEBUG_SYMBOLS
---help---
Build with debug symbols (needed for use with a debugger).
+config FRAME_POINTER
+ bool "Compile the NuttX with frame pointers"
+ default n
+ help
+ If you say Y here the resulting NuttX image will be slightly
+ larger and slower, but it gives very useful debugging information
+ in case of bugs.
+
Review comment:
```suggestion
config FRAME_POINTER
bool "Compile the NuttX with frame pointers"
default n
---help---
If you say Y here the resulting NuttX image will be slightly
larger and slower, but it gives very useful debugging information
in case of bugs.
```
Kconfig files are indented only with tabs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5082: compile/flags: add FRAME_POINTER into Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5082:
URL: https://github.com/apache/incubator-nuttx/pull/5082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org