You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Bertrand Delacretaz <bd...@apache.org> on 2015/09/01 12:51:57 UTC

Trouble with org.apache.felix.http.jetty 3.1.0

Hi,

FYI I just reverted to V3.0.2 of that module in launchpad
(http://svn.apache.org/r1700482) as this fixes SLING-4978 - I'd like
to investigate deeper but will first look at other failing integration
tests.

Changing to 3.1.0 introduced both SLING-4978 and SLING-4976 - does
anyone know more about that version 3.1.0, is there a major (Jetty)
change in it?

-Bertrand

Re: Trouble with org.apache.felix.http.jetty 3.1.0

Posted by Carsten Ziegeler <cz...@apache.org>.
Am 01.09.15 um 13:18 schrieb Bertrand Delacretaz:
> On Tue, Sep 1, 2015 at 1:03 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ...I think we should go to 3.1 again and fix either the test cases or
>> for SLING-4978 the implementation...
> 
> Yes that's my idea, I'd just like to fix the remaining failing tests
> at [1] first, to have a clean baseline.
> 
> If someone has hints about request.getRequestURI() not including a
> trailing ;v=1.1behavior anymore (SLING-4978) they are welcome.
> 

Actually this was discussed/handled with SLING-4804 - it seems we have
to reopen that one then.

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: Trouble with org.apache.felix.http.jetty 3.1.0

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Sep 1, 2015 at 1:03 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ...I think we should go to 3.1 again and fix either the test cases or
> for SLING-4978 the implementation...

Yes that's my idea, I'd just like to fix the remaining failing tests
at [1] first, to have a clean baseline.

If someone has hints about request.getRequestURI() not including a
trailing ;v=1.1behavior anymore (SLING-4978) they are welcome.

-Bertrand

[1] https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/

Re: Trouble with org.apache.felix.http.jetty 3.1.0

Posted by Carsten Ziegeler <cz...@apache.org>.
Am 01.09.15 um 12:51 schrieb Bertrand Delacretaz:
> Hi,
> 
> FYI I just reverted to V3.0.2 of that module in launchpad
> (http://svn.apache.org/r1700482) as this fixes SLING-4978 - I'd like
> to investigate deeper but will first look at other failing integration
> tests.
> 
> Changing to 3.1.0 introduced both SLING-4978 and SLING-4976 - does
> anyone know more about that version 3.1.0, is there a major (Jetty)
> change in it?
> 
Hi,

yes, there has been a major Jetty update. I thought we have a fix in
Sling for SLING-4978; at least some time back I already mentioned this
problem.
As mentioned for SLING-4976 I think we now have the correct behaviour
that a double slash is interpreted as a single slash.

So I think we should go to 3.1 again and fix either the test cases or
for SLING-4978 the implementation.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org