You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dtrodrigues <gi...@git.apache.org> on 2018/06/16 18:01:32 UTC
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
GitHub user dtrodrigues opened a pull request:
https://github.com/apache/nifi/pull/2800
NIFI-5317 - support non-ASCII X-Mailer header
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dtrodrigues/nifi NIFI-5317
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2800
----
commit 263413c37c0db84e3269aa2a0118c00b77226813
Author: Dustin Rodrigues <du...@...>
Date: 2018-06-16T18:01:00Z
NIFI-5317 - support non-ASCII X-Mailer header
----
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2800
+1, merging to master, thanks @dtrodrigues @ottobackwards
---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195934550
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java ---
@@ -137,7 +137,7 @@ public void testOutgoingMessage() throws Exception {
public void testOutgoingMessageWithOptionalProperties() throws Exception {
// verifies that optional attributes are set on the outgoing Message correctly
--- End diff --
I don't see the non-ascii, am I missing something?
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by dtrodrigues <gi...@git.apache.org>.
Github user dtrodrigues commented on the issue:
https://github.com/apache/nifi/pull/2800
Header setting is now refactored into a function and there are tests for non-ascii headers
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2800
+1 LGTM, mvn install and contrib-check pass, use of MineType utility per best practices.
---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2800
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by dtrodrigues <gi...@git.apache.org>.
Github user dtrodrigues commented on the issue:
https://github.com/apache/nifi/pull/2800
I updated the test X-Mailer header to be more explicit that it's non-ASCII
---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by dtrodrigues <gi...@git.apache.org>.
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195935356
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java ---
@@ -137,7 +137,7 @@ public void testOutgoingMessage() throws Exception {
public void testOutgoingMessageWithOptionalProperties() throws Exception {
// verifies that optional attributes are set on the outgoing Message correctly
--- End diff --
The test is for the non-ascii accented 'i' here in the first 'i' of "TestingNífi" on lines 140/167 as well as for the accented 'u' in "Búlk"
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2800
This looks good, just two comments.
1. If we are going to add support for non-ascii, the test should test non-ascii, can we add that?
2. We now have a pattern of use in two places using with a try catch around setting headers with encoding, maybe we should have a function?
---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195934504
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java ---
@@ -320,6 +320,15 @@ public void onScheduled(final ProcessContext context) {
this.attributeNamePattern = attributeNameRegex == null ? null : Pattern.compile(attributeNameRegex);
}
--- End diff --
We should include the header name in the message
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2800
Yikes, sorry.
---