You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 08:53:12 UTC

[GitHub] [arrow] kiszk commented on a change in pull request #8011: ARROW-9803: [Go] Add initial support for s390x

kiszk commented on a change in pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#discussion_r473781339



##########
File path: go/arrow/type_traits_decimal128.go
##########
@@ -39,8 +40,13 @@ func (decimal128Traits) BytesRequired(n int) int { return Decimal128SizeBytes *
 
 // PutValue
 func (decimal128Traits) PutValue(b []byte, v decimal128.Num) {
-	binary.LittleEndian.PutUint64(b[:8], uint64(v.LowBits()))
-	binary.LittleEndian.PutUint64(b[8:], uint64(v.HighBits()))
+	if runtime.GOARCH == "s390x" {

Review comment:
       Good point.
   
   Can we use `const` at the package level? For example,
   ```
   package ...
   
   const BigEndian = runtime.GOARCH == "s390x"
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org