You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by jean-frederic clere <jf...@gmail.com> on 2010/01/14 15:23:05 UTC

[VOTE] Release build 6.0.23

The candidates binaries are available here:
http://people.apache.org/~jfclere/tomcat-6/v6.0.23/

According to the release process, the 6.0.23 tag is:
[ ] Broken
[ ] Alpha
[ ] Beta
[ ] Stable

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by sebb <se...@gmail.com>.
On 14/01/2010, jean-frederic clere <jf...@gmail.com> wrote:
> The candidates binaries are available here:
>  http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
>
>  According to the release process, the 6.0.23 tag is:
>  [ ] Broken
>  [ ] Alpha
>  [ ] Beta
>  [ ] Stable

The files in the extras/ directory don't have a version tag in their names.
Nor do their MANIFEST files have an Implementation version.
Might be useful to have one or both version indications.

It would be nice if all the jars included the Implementation version
(i.e. 6.0.23) in the Manifest.

>  Cheers
>
>  Jean-Frederic
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Henri Gomez <he...@gmail.com>.
If you provide new Tomcat binaries, it will be 6.0.24 ?

2010/1/15 Mladen Turk <mt...@apache.org>:
> On 01/15/2010 08:22 AM, jean-frederic clere wrote:
>>
>> We have to fix the TCK failures, We shouldn't release some things which
>> is not TCK compliant.
>
> +1
>
>
> Regards
> --
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Mladen Turk <mt...@apache.org>.
On 01/15/2010 08:22 AM, jean-frederic clere wrote:
>
> We have to fix the TCK failures, We shouldn't release some things which
> is not TCK compliant.

+1


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
On 01/15/2010 12:22 AM, jean-frederic clere wrote:
> We have to fix the TCK failures
+1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Mark Thomas <ma...@apache.org>.
On 15/01/2010 07:42, Rainer Jung wrote:
> On 15.01.2010 08:22, jean-frederic clere wrote:
>> On 01/14/2010 10:45 PM, Filip Hanik - Dev Lists wrote:
>>>
>>> if all we find wrong is line endings, then I would suggest
>>> 1. fix the packaging script
>>> 2. Add the fix to the tag
>>> 3. rerun the script
>>> 4. post the new binaries
>>
>> We have to fix the TCK failures, We shouldn't release some things which
>> is not TCK compliant.
>> Rollback r899138 should fix those TCK issues, no?
> 
> I think Mark's proposal to fix it is r899420. I guess he'll run the TCK
> again with that revision included.

Correct. Sorry, I should have said when I proposed that fix. With
r899420 applied there are 5 remaining TCK failures. These are all
expected since they are caused by the webapps trying to open network
connections to test things.

Rolling back 899138 would achieve the same purpose but since we have to
re-tag lets move forwards and apply r899420 instead.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Rainer Jung <ra...@kippdata.de>.
On 15.01.2010 08:22, jean-frederic clere wrote:
> On 01/14/2010 10:45 PM, Filip Hanik - Dev Lists wrote:
>>
>> if all we find wrong is line endings, then I would suggest
>> 1. fix the packaging script
>> 2. Add the fix to the tag
>> 3. rerun the script
>> 4. post the new binaries
>
> We have to fix the TCK failures, We shouldn't release some things which
> is not TCK compliant.
> Rollback r899138 should fix those TCK issues, no?

I think Mark's proposal to fix it is r899420. I guess he'll run the TCK 
again with that revision included.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by jean-frederic clere <jf...@gmail.com>.
On 01/14/2010 10:45 PM, Filip Hanik - Dev Lists wrote:
> 
> if all we find wrong is line endings, then I would suggest
> 1. fix the packaging script
> 2. Add the fix to the tag
> 3. rerun the script
> 4. post the new binaries

We have to fix the TCK failures, We shouldn't release some things which
is not TCK compliant.
Rollback r899138 should fix those TCK issues, no?

Cheeers

Jean-Frederic

> 
> Filip
> 
> On 01/14/2010 07:23 AM, jean-frederic clere wrote:
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
>>
>> According to the release process, the 6.0.23 tag is:
>> [ ] Broken
>> [ ] Alpha
>> [ ] Beta
>> [ ] Stable
>>
>> Cheers
>>
>> Jean-Frederic
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>    
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
if all we find wrong is line endings, then I would suggest
1. fix the packaging script
2. Add the fix to the tag
3. rerun the script
4. post the new binaries

Filip

On 01/14/2010 07:23 AM, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
>
> According to the release process, the 6.0.23 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [ ] Stable
>
> Cheers
>
> Jean-Frederic
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by jean-frederic clere <jf...@gmail.com>.
On 01/14/2010 04:51 PM, Mark Thomas wrote:
> On 14/01/2010 14:23, jean-frederic clere wrote:
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
>>
>> According to the release process, the 6.0.23 tag is:
>> [ ] Broken
>> [ ] Alpha
>> [ ] Beta
>> [ ] Stable
> 
> Minor niggle. The .asc file is missing for apache-tomcat-6.0.23.exe

Oops fixed thanks.

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Mark Thomas <ma...@apache.org>.
On 14/01/2010 14:23, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
> 
> According to the release process, the 6.0.23 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [ ] Stable

Minor niggle. The .asc file is missing for apache-tomcat-6.0.23.exe

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Yoav Shapira <yo...@apache.org>.
On Thu, Jan 14, 2010 at 1:32 PM, Mark Thomas <ma...@apache.org> wrote:
> On 14/01/2010 14:23, jean-frederic clere wrote:
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
>>
>> According to the release process, the 6.0.23 tag is:
>> [ ] Broken
>> [ ] Alpha
>> [X] Beta
>> [ ] Stable

I noticed the ZIP line-endings since I tested on a Windows box.  That
with Mark's reported 22 failures means Beta.

Yoav

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release build 6.0.23

Posted by Mark Thomas <ma...@apache.org>.
On 14/01/2010 14:23, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.23/
> 
> According to the release process, the 6.0.23 tag is:
> [ ] Broken
> [ ] Alpha
> [X] Beta
> [ ] Stable

Checked
-src.tz.gz
-src.zip
-windows-x64.zip
-windows-x86.zip
.exe
.zip

Signatures match
MD5s match
Key in ASF web of trust

Three files have unix line endings in the -src.zip distro
res/maven/dbcp.pom                 (fixed in svn)
res/META-INF/default.notice        (proposal in STATUS.txt)
res/META-INF/jasper-jdt.jar.notice (proposal in STATUS.txt)

I'm not concerned about any of these.

.zip distro starts with no obvious errors

Config files for *.zip distributions have unix line endings. That is
going to be a pain for Windows users. I think this needs fixing for a
stable release.

Testing on 64-bit Windows
-x86.zip distro starts with no obvious errors on 64-bit JVM and uses BIO
-x86.zip distro starts with no obvious errors on 32-bit JVM and uses APR
-x64.zip distro starts with no obvious errors on 64-bit JVM and uses APR
-x64.zip distro starts with no obvious errors on 32-bit JVM and uses BIO
Nice :)

Windows installer detects 64-bit OS and installs correct version of
APR/native. Tomcat starts happily.
Uninstaller cleans up after itself correctly.

JSP 2.1b TCK tests pass without a security manager
JSP 2.1b TCK tests pass with a security manager
Servlet 2.5 TCK tests pass without a security manager
Servlet 2.5 TCK tests pass with a security manager had 27 failures

5 failures were expected since the tests try to create a network
connection and the security manager prevents that. I'm not concerned
about these.

22 failures were caused by the fix for 47774. I think this needs fixing
for a stable release.

Unit tests all pass.

I'll work on patches for the TCK failures with a security manager and
the line-endings in the binary distributions.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org