You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by hzbarcea <gi...@git.apache.org> on 2015/07/21 19:37:07 UTC
[GitHub] incubator-brooklyn pull request: Fix warnings in eclipse
GitHub user hzbarcea opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/764
Fix warnings in eclipse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzbarcea/incubator-brooklyn eclipse-errors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit 8e85bfe47b4d111e44e9d93886a1541d5ecdc15e
Author: Hadrian Zbarcea <ha...@apache.org>
Date: 2015-07-21T01:39:29Z
Fix warnings in eclipse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix warnings in eclipse
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/764#issuecomment-123788549
Thanks @hzbarcea - change looks sensible. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix warnings in eclipse
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/764#issuecomment-123788198
Test failure is unrelated: `testIsPortAvailableReportsTrueWhenPortIsFree` "requires that at least some ports near 58769+ not be in use." It's either an environment problem, or it's too strict an assertion when testing `Networking.isPortAvailable`. It assumes that at least 5 of the 10 ports in the range 58769-58779 will be available. If they are not, the assumption was that `isPortAvailable` may well not be working.
I'll look at relaxing that in a separate PR. If it keeps failing (with no ports available) then we may have to move that to be an integration test, rather than asfbot running it in the normal unit test environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix warnings in eclipse
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/764#issuecomment-123790921
@aledsage,
Thanks. Fwiw, that was in Kepler, in Luna I don't have that problem and Mars (relatively fresh) doesn't have a stable Groovy plugin yet, so I didn't try. I am also testing with Oracle JDK 7 and 8 and OpenJDK 1.7.0_79 with no issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix warnings in eclipse
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---